From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69156C43381 for ; Wed, 20 Feb 2019 08:46:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A9932146E for ; Wed, 20 Feb 2019 08:46:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="bNPk/vxK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbfBTIqP (ORCPT ); Wed, 20 Feb 2019 03:46:15 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40154 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbfBTIqO (ORCPT ); Wed, 20 Feb 2019 03:46:14 -0500 Received: by mail-wr1-f66.google.com with SMTP id q1so24969485wrp.7 for ; Wed, 20 Feb 2019 00:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cxYhWQ2WuT/GVD6nPi29RJ1mSQ6mD/DK8CDvO6srdFc=; b=bNPk/vxKtlnCUCPNoPaNQOgQfR2K49+ID45f7VI6blgZNPfAuJO9dp8aH9sxis67wO RNPdipvDQg9NF6G9G3ovtm+IaFmx2a/kg9WMYuisdNPopyD8ntK3WnoYwt2bn9OlZ4wY b52piGhNZS4I+8r6/1LRjZMvEiX5h5dhVUDCoroM/eH3lAk43URxwDpeGcJez7Qo3wsc HJ/m/FsX6IHhfqRwWB+Bv6RcrVzy+wR35DnN67cnULZIjnAwq9wXwwHUYzrkd3C8EYJc puTH3WNpHzXC4mqF7VOVMBjlmlhZFaICBl/1GBZkRHLzcia4Z37gd3sOona0gEYfdc4/ K8kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cxYhWQ2WuT/GVD6nPi29RJ1mSQ6mD/DK8CDvO6srdFc=; b=f7gRH909a8bEv1Ydp52diHLA8m2x3I6dO6/1MfPz9rHog5JZ1ljB4QJiLa9Wg+qcqN MRMW3mIf7Z8JMAyCAl5Hc/zbGv4MtyLH5auxGxS0Y4sj3hPGZ51cOW6MTpGeiuM85lS4 wb2GjErqVcRgv+Xy2W75rKPs1odqJtjyzFrSW1UI2Zfr9fNK4+3kMddanICEsdUis9V0 s45YLp2COUOcPcUhE56S5MY0wjTMjLXZF5ccrlkO1zYiA/nvzGOvV0JIw3/tvZ7prsNS uDmCufnJQf8ZltzYE+4m5XebQNyO+7W3pqfVXGhctywh0iOtI503WJIokNkVknJYykDO xOdA== X-Gm-Message-State: AHQUAuae2MQbvXHs99+2bfI2HRrhd5WAPnZgAeyp452wXAd5YauiEl9H 641qsRpFpWyoso/It8t24je9Sg== X-Google-Smtp-Source: AHgI3IYo4hTvJIGDBOd8CZyGSdnJoGNhw3FECsoY2LRfdN3WoTql39o3uL21nrGxtgAKf692XqixOQ== X-Received: by 2002:adf:fa0d:: with SMTP id m13mr23384389wrr.93.1550652373128; Wed, 20 Feb 2019 00:46:13 -0800 (PST) Received: from localhost (ip-213-220-234-21.net.upcbroadband.cz. [213.220.234.21]) by smtp.gmail.com with ESMTPSA id d2sm9912797wrq.94.2019.02.20.00.46.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 00:46:12 -0800 (PST) Date: Wed, 20 Feb 2019 09:36:38 +0100 From: Jiri Pirko To: George Wilkie Cc: "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net v2] team: use operstate consistently for linkup Message-ID: <20190220083638.GK3080@nanopsycho> References: <20190220081911.803-1-gwilkie@vyatta.att-mail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220081911.803-1-gwilkie@vyatta.att-mail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Feb 20, 2019 at 09:19:11AM CET, gwilkie@vyatta.att-mail.com wrote: >When a port is added to a team, its initial state is derived >from netif_carrier_ok rather than netif_oper_up. >If it is carrier up but operationally down at the time of being >added, the port state.linkup will be set prematurely. >port state.linkup should be set consistently using >netif_oper_up rather than netif_carrier_ok. > >Fixes: f1d22a1e0595 ("team: account for oper state") >Signed-off-by: George Wilkie Acked-by: Jiri Pirko