From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B606BC43381 for ; Wed, 20 Feb 2019 15:08:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D0D820859 for ; Wed, 20 Feb 2019 15:08:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="3PqJijpb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfBTPIa (ORCPT ); Wed, 20 Feb 2019 10:08:30 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:59817 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbfBTPIa (ORCPT ); Wed, 20 Feb 2019 10:08:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9HMpo+Hp8jBO167QY5FNEwtF2Z7S2HU8BzwQSazNJvQ=; b=3PqJijpb3g4NCOdJ8lTPeig/in OUSHUTb4FwprGqnY5AvNWcJLHXAqJm1K6k8Z1vUFQMGPO1ntkwINiqTIwuAOyxGnlj8K9q/UrdV0O Px4c3bWKd0PGov3gsOSvabnQgk8/bYmXQkp4qSfb6w/wQYpEdgpD4Dp6ghVJ2hj78tF0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gwTU2-0006v3-7D; Wed, 20 Feb 2019 16:08:26 +0100 Date: Wed, 20 Feb 2019 16:08:26 +0100 From: Andrew Lunn To: Tristram.Ha@microchip.com Cc: Sergio Paracuellos , Florian Fainelli , Pavel Machek , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next 2/4] net: dsa: microchip: add MIB counter reading support Message-ID: <20190220150826.GI13075@lunn.ch> References: <1550620623-13036-1-git-send-email-Tristram.Ha@microchip.com> <1550620623-13036-3-git-send-email-Tristram.Ha@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550620623-13036-3-git-send-email-Tristram.Ha@microchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +static void mib_monitor(struct timer_list *t) > +{ > + struct ksz_device *dev = from_timer(dev, t, mib_read_timer); > + const struct dsa_port *dp; > + struct net_device *netdev; > + struct ksz_port_mib *mib; > + struct ksz_port *p; > + int i; > + > + mod_timer(&dev->mib_read_timer, jiffies + dev->mib_read_interval); > + > + /* Check which port needs to read MIB counters. */ > + for (i = 0; i < dev->mib_port_cnt; i++) { > + p = &dev->ports[i]; > + if (!p->on) > + continue; > + dp = dsa_to_port(dev->ds, i); > + netdev = dp->slave; > + > + mib = &p->mib; > + mutex_lock(&mib->cnt_mutex); > + > + /* Read only dropped counters when link is not up. */ > + if (netdev && netdev->phydev && !netdev->phydev->link) > + mib->cnt_ptr = dev->reg_mib_cnt; > + mutex_unlock(&mib->cnt_mutex); > + p->read = true; > + } > + schedule_work(&dev->mib_read); > +} Hi Tristram This is much easier to understand. Thanks for making the change. However, i suspect Florian was suggesting you use netif_carrier_ok(netdev), not poke around inside the phydev structure. Andrew