From: David Miller <davem@davemloft.net>
To: hoang.h.le@dektech.com.au
Cc: jon.maloy@ericsson.com, maloy@donjonn.com,
ying.xue@windriver.com, netdev@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: [net-next 3/3] tipc: smooth change between replicast and broadcast
Date: Thu, 21 Feb 2019 16:00:50 -0800 (PST) [thread overview]
Message-ID: <20190221.160050.1467604509752685304.davem@davemloft.net> (raw)
In-Reply-To: <20190219113054.13517-3-hoang.h.le@dektech.com.au>
From: Hoang Le <hoang.h.le@dektech.com.au>
Date: Tue, 19 Feb 2019 18:30:54 +0700
> +static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
> + struct tipc_mc_method *method,
> + struct tipc_nlist *dests,
> + u16 *cong_link_cnt)
> +{
> + struct sk_buff_head tmpq;
> + struct sk_buff *_skb;
> + struct tipc_msg *hdr, *_hdr;
Reverse christmas tree please.
> @@ -300,6 +372,9 @@ int tipc_mcast_xmit(struct net *net, struct sk_buff_head *pkts,
> u16 *cong_link_cnt)
> {
> struct sk_buff_head inputq, localq;
> + struct sk_buff *skb;
> + struct tipc_msg *hdr;
> + bool rcast = method->rcast;
> int rc = 0;
Likewise.
Thanks.
prev parent reply other threads:[~2019-02-22 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 11:30 [net-next 1/3] tipc: support broadcast/replicast configurable for bc-link Hoang Le
2019-02-19 11:30 ` [net-next 2/3] tipc: introduce new capability flag for cluster Hoang Le
2019-02-19 11:30 ` [net-next 3/3] tipc: smooth change between replicast and broadcast Hoang Le
2019-02-22 0:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221.160050.1467604509752685304.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hoang.h.le@dektech.com.au \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).