From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58A09C43381 for ; Thu, 21 Feb 2019 21:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22DEF20661 for ; Thu, 21 Feb 2019 21:21:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="eG3iEPWL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726656AbfBUVVY (ORCPT ); Thu, 21 Feb 2019 16:21:24 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:44312 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbfBUVVX (ORCPT ); Thu, 21 Feb 2019 16:21:23 -0500 Received: by mail-pf1-f196.google.com with SMTP id a3so14233pff.11 for ; Thu, 21 Feb 2019 13:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=je/vabS6CvNMbOZEjYHuVgl0eevy/NZGM8Lcw/s2yso=; b=eG3iEPWLETy5h+Y+aktRuxEyNLX6N3JgDnPZFOGMIF9Sh+Le161qHzY+9CWlLG+YD+ xxXS5v6+YLFjhuF2lkmcwJ3ylac6Ve9BXKTl5ZuArPf8O3E3E6OhwjT3TJdtSGRLV0fr tbd7CjRT0lllPfseTvV2ulb8IMKCfo6IECgzcYlnzUiyu1+j56mLYzhfDkh8f7wQ1KHm J288Ru8G58pmw0hRgiDpN8lOlbSQPRH/F0m3mDpf7zA1Gxlqs7FDD9rI8y5HM9dL9TFU 1g7UXvnD10eX8/Bj8Y8/3w4R6CLZ4VM3ki0+UFf20kf7hPdZuxkquB17Q5ISMyjJYQwa gtdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=je/vabS6CvNMbOZEjYHuVgl0eevy/NZGM8Lcw/s2yso=; b=kl1+eCLLN9pcR3/BQg7aaCmPXEP1DR8xJ/1OxfPahAqcxGXr3QgC4Bk4NcxuvUwqGB 6C3h5pldYIIfMx8lR5/lVWjd8NBdCimLzvrAKRO8XAlJi78IrrdwngeH+ZI7ZRTPJXL1 AdVaJ2I2cPGKUHCR5IN/JxnD7TsbPBTwhSraYY7EwPvRIXbhaS9n4w6wPEf6fHbubXuL /p4qETTdq5zTcYq6ukVkRR33XgM9VpV+aO78GvsnnaT7pJ4aSlqPd0LVvuQA8086bUvP ij5ichYB0EFBchpdBGm2YSLeU7+THp/LvfinOA5LG3DKWyv7GOFH3D9lCtvVO2o5r62I H4Lw== X-Gm-Message-State: AHQUAuaToCs2zpP1++vs0/7wYU8rZdcypebdv363DLIqfEcFUJ92r8nT 7ruNdT1S4F5xgwaRZ7uexlCInQ== X-Google-Smtp-Source: AHgI3IbtImm8cbJ02+rMqvAKbRZQVgOAAQUyDlD9m6W0yFzkvYJpM/d1JIJYZMob/ib4hs8kfI3fDQ== X-Received: by 2002:a63:1d1d:: with SMTP id d29mr545134pgd.49.1550784082933; Thu, 21 Feb 2019 13:21:22 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p29sm30344085pgm.78.2019.02.21.13.21.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 13:21:22 -0800 (PST) Date: Thu, 21 Feb 2019 10:56:31 -0800 From: Stephen Hemminger To: Steve Wise Cc: dsahern@gmail.com, leon@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v1 iproute2-next 2/4] Sync up rdma_netlink.h Message-ID: <20190221105631.7dfa5217@shemminger-XPS-13-9360> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 21 Feb 2019 08:19:07 -0800 Steve Wise wrote: > Pull in the latest rdma_netlink.h to get the RDMA_NLDEV_CMD_NEWLINK / > RDMA_NLDEV_CMD_DELLINK API. > > Signed-off-by: Steve Wise > --- > rdma/include/uapi/rdma/rdma_netlink.h | 74 +++++++++++++++++++++++++++-------- > 1 file changed, 58 insertions(+), 16 deletions(-) > > diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h > index 04c80cebef49..23a90ad52485 100644 > --- a/rdma/include/uapi/rdma/rdma_netlink.h > +++ b/rdma/include/uapi/rdma/rdma_netlink.h > @@ -5,8 +5,7 @@ > #include > > enum { > - RDMA_NL_RDMA_CM = 1, > - RDMA_NL_IWCM, > + RDMA_NL_IWCM = 2, > RDMA_NL_RSVD, > RDMA_NL_LS, /* RDMA Local Services */ > RDMA_NL_NLDEV, /* RDMA device interface */ You can't just drop elements from user ABI headers. That is a break of kernel ABI guarantee. Instead, mark unused elements: enum { RDMA_NL_RDMA_CM = 1, /* deprecated */ RDMA_NL_IWCM, ...