From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com,
miquel.raynal@bootlin.com, nadavh@marvell.com,
stefanc@marvell.com, mw@semihalf.com
Subject: Re: [PATCH net-next 1/7] net: phy: marvell10g: Use get_features to get the PHY abilities
Date: Thu, 21 Feb 2019 11:31:46 +0100 [thread overview]
Message-ID: <20190221113146.119e67d4@bootlin.com> (raw)
In-Reply-To: <20190221102215.jg7bsxfdjkqrf6xn@shell.armlinux.org.uk>
Hello Russell,
On Thu, 21 Feb 2019 10:22:15 +0000
Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote:
>> + return 0;
>> +}
>> +
>> +static int mv3310_get_features(struct phy_device *phydev)
>> +{
>> + int ret, val;
>
>Please try to keep the formatting/style consistent in the file you are
>editing. A blank line here would do that. Thanks.
Sorry, I missed that (and so did checkpatch apparently). I'll send a V2.
Thanks,
Maxime
next prev parent reply other threads:[~2019-02-21 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 9:51 [PATCH net-next 0/7] net: phy: marvell10g: Add 2.5GBaseT Maxime Chevallier
2019-02-21 9:51 ` [PATCH net-next 1/7] net: phy: marvell10g: Use get_features to get the PHY abilities Maxime Chevallier
2019-02-21 10:22 ` Russell King - ARM Linux admin
2019-02-21 10:31 ` Maxime Chevallier [this message]
2019-02-22 18:42 ` Heiner Kallweit
2019-02-22 20:45 ` Maxime Chevallier
2019-02-21 9:51 ` [PATCH net-next 2/7] net: phy: marvell10g: Use linkmode_set_bit helper instead of __set_bit Maxime Chevallier
2019-02-21 9:51 ` [PATCH net-next 3/7] net: phy: marvell10g: Use 2500BASEX when using 2.5GBASET Maxime Chevallier
2019-02-21 9:51 ` [PATCH net-next 4/7] net: phy: marvell10g: Use a #define for 88X3310 family id Maxime Chevallier
2019-02-21 9:51 ` [PATCH net-next 5/7] net: phy: marvell10g: Force reading of 2.5/5G Maxime Chevallier
2019-02-21 9:51 ` [PATCH net-next 6/7] net: mvpp2: Add 2.5GBaseT support Maxime Chevallier
2019-02-21 9:51 ` [PATCH net-next 7/7] net: phy: marvell10g: add support for the 88x2110 PHY Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221113146.119e67d4@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).