From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com,
idosch@mellanox.com, jiri@mellanox.com,
rmk+kernel@armlinux.org.uk
Subject: Re: [PATCH net-next 0/2] net: dsa: VLAN devices w/ filtering
Date: Fri, 22 Feb 2019 11:53:54 -0800 (PST) [thread overview]
Message-ID: <20190222.115354.1384012175579493298.davem@davemloft.net> (raw)
In-Reply-To: <20190220223539.22106-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 20 Feb 2019 14:35:37 -0800
> This patch series supports having VLAN devices on top of DSA/switch
> ports while the switch has VLAN filtering globally turned on (as is the
> case with Broadcom switches). Whether the switch does global or per-port
> VLAN filtering, having VLAN entries for these VLAN devices is
> beneficial.
>
> We take care of a few possibly problematic cases:
>
> - adding a VLAN device while there is an existing VLAN entry created by
> a VLAN aware bridge. The entire bridge's VLAN database and not just
> the specific bridge port is being checked to be safe and conserative
>
> - adding a bridge VLAN entry when there is an existing VLAN device
> created is also not possible because that would lead to the bridge
> being able to manipulate the VLAN device's VID/attributes under its feet
>
> - enslaving a VLAN device into a VLAN aware bridge since that duplicates
> functionality already offered by the VLAN aware bridge
>
> Here are the different test cases that were run to exercise this:
...
Series applied, thanks Florian.
prev parent reply other threads:[~2019-02-22 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 22:35 [PATCH net-next 0/2] net: dsa: VLAN devices w/ filtering Florian Fainelli
2019-02-20 22:35 ` [PATCH net-next 1/2] net: dsa: Deny enslaving VLAN devices into VLAN aware bridge Florian Fainelli
2019-02-20 22:35 ` [PATCH net-next 2/2] net: dsa: Add ndo_vlan_rx_{add,kill}_vid implementation Florian Fainelli
2019-02-22 19:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222.115354.1384012175579493298.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).