From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01572C43381 for ; Fri, 22 Feb 2019 18:10:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8665205C9 for ; Fri, 22 Feb 2019 18:10:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="LXYmwmve" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727480AbfBVSJ7 (ORCPT ); Fri, 22 Feb 2019 13:09:59 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:35970 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725986AbfBVSJ7 (ORCPT ); Fri, 22 Feb 2019 13:09:59 -0500 Received: by mail-pg1-f194.google.com with SMTP id r124so1477181pgr.3 for ; Fri, 22 Feb 2019 10:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XqvGzTZYX73lyylCKKhJsFO2NMBEggDs9eTXjFHmWGQ=; b=LXYmwmveYfwoMwYW+q4jlV4v5cJpIFNLp8ssrNpXDh8DjqDTxItWDTzQCFlqlLrw90 Vdi2P6T96Pnn0KYdMRBq46yakres//lJB8b/HxuqBnoKzt1G/xlXprAP/EEpmwXa8WR6 qGmW9pgR/mZPIJY59hM237kZUYOsM4AFd8Cpzqnnp1pxeZP/v9xnTBTQbBeuYKwIG2OB Zpzi8DemN0xNE6S7zxTSnvDVeLXziBfZJH7OE40HAB2yqPhs0lTtbuvGmdYLe2QocPUT mW3LawQ729jMek5UADPeMf+5Sl9TG8qwUeR+3mhAPrx+y9Z/5anlPNVScblXIC4GV5C2 BR0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XqvGzTZYX73lyylCKKhJsFO2NMBEggDs9eTXjFHmWGQ=; b=Sy1t58YUsAuuMuR/q07gHzgYAlrnnsFGePu3qlrrtVAj0u4yTybbeIk56Hv6NcLW0s GeqnpCOzg10VI4Lhp4vAqgD5Pp/KjnuXZBiPGkcpwkqtPpWLrFvX01o5XFYV0Ra1u196 o9onk2XTmnTPzndx0BTwTJjXmHr49dPbBez1YvsDZShEnwl6yUu7d6ByQxvZ7uCw+KpQ 0RhDfRDE2G8YSFHtZryFLDXmPS1DxeV1JGI1KEx0Yb/7kGCgouMLjESaKR9V0ASKBXT8 GTEBgqjjvN0PUjOO/VZbZftzkdHu73Jt25NQew/SBnzs/VDZag0fyedGk4s9qZK0zgEp WGww== X-Gm-Message-State: AHQUAuZVZWuM1u1AqQzhWQdiu48DwuKA3gRvUgukAcEsQu4VQpop0Ct9 XPwMfhWvvWOxtpLmbPQGc5qWkKJ/KhQ= X-Google-Smtp-Source: AHgI3IbVbsIOSmITtwTs3RkVVC9SaNJbeH/inhAPOYzOoY61N8QjwVUhlmsIG9DOqS05ySPefAhUWg== X-Received: by 2002:a63:2f47:: with SMTP id v68mr5101570pgv.144.1550858997720; Fri, 22 Feb 2019 10:09:57 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d129sm2564897pgc.59.2019.02.22.10.09.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Feb 2019 10:09:57 -0800 (PST) Date: Fri, 22 Feb 2019 10:09:53 -0800 From: Stephen Hemminger To: Moshe Shemesh Cc: "netdev@vger.kernel.org" , Stephen Hemminger Subject: Re: [RFC] rtnetlink: handle multiple vlan tags in set_vf_vlan Message-ID: <20190222100953.03b95ae6@shemminger-XPS-13-9360> In-Reply-To: <24d8a96d-4bac-fe8d-1308-c2caee2a9d2c@mellanox.com> References: <20190221175436.10767-1-sthemmin@microsoft.com> <24d8a96d-4bac-fe8d-1308-c2caee2a9d2c@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 22 Feb 2019 04:58:06 +0000 Moshe Shemesh wrote: > On 2/21/2019 7:54 PM, Stephen Hemminger wrote: > > The netlink API for IFLA_VF_VLAN_LIST allows multiple VLAN tags to > > be passed (and the message was validated) but only the first VLAN > > tag was being passed to the device. Change to iterate over each tag received. > > > > Fixes: 79aab093a0b5 ("net: Update API for VF vlan protocol 802.1ad support") > > Signed-off-by: Stephen Hemminger > > --- > > net/core/rtnetlink.c | 19 ++++++++++--------- > > 1 file changed, 10 insertions(+), 9 deletions(-) > > > > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > > index a51cab95ba64..3a9ec988ae21 100644 > > --- a/net/core/rtnetlink.c > > +++ b/net/core/rtnetlink.c > > @@ -2207,11 +2207,10 @@ static int do_setvfinfo(struct net_device *dev, struct nlattr **tb) > > if (tb[IFLA_VF_VLAN_LIST]) { > > struct ifla_vf_vlan_info *ivvl[MAX_VLAN_LIST_LEN]; > > struct nlattr *attr; > > - int rem, len = 0; > > + int i, rem, len = 0; > > > > - err = -EOPNOTSUPP; > > if (!ops->ndo_set_vf_vlan) > > - return err; > > + return -EOPNOTSUPP; > > > > nla_for_each_nested(attr, tb[IFLA_VF_VLAN_LIST], rem) { > > if (nla_type(attr) != IFLA_VF_VLAN_INFO || > > @@ -2224,13 +2223,15 @@ static int do_setvfinfo(struct net_device *dev, struct nlattr **tb) > > > > len++; > > } > > - if (len == 0) > > - return -EINVAL; > > > > - err = ops->ndo_set_vf_vlan(dev, ivvl[0]->vf, ivvl[0]->vlan, > > - ivvl[0]->qos, ivvl[0]->vlan_proto); > > - if (err < 0) > > - return err; > > + err = -EINVAL; /* empty list error */ > > + for (i = 0; i < len; i++) { > > + err = ops->ndo_set_vf_vlan(dev, ivvl[i]->vf, > > + ivvl[i]->vlan, ivvl[i]->qos, > > + ivvl[i]->vlan_proto); > > Doing that each vlan will just overwrite the vf vlan configuration set > by its preceding one. > Note #define MAX_VLAN_LIST_LEN 1 > The point here was that I had to add the rtnl interface to set vf vlan > with option to set vf vlan protocol. While doing that I was asked to add > option to get a list of vlans from user to support QinQ, so once it will > be needed there won't be a need to add another rtnl interface. > > The driver which will support setting double vlan or more per vf will > change MAX_VLAN_LIST_LEN and change the ndo function. > OK, then the original code kind of makes sense now. Maybe the whole loop could be eliminated. I expected that the vlan list was for allowing multiple vlan's to go to a single VF but it is really a future (unlikely to ever be implemented) support for QinQ.