From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-doc@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 2/2] doc: add phylink documentation to the networking book
Date: Fri, 22 Feb 2019 11:20:33 +0000 [thread overview]
Message-ID: <20190222112033.odgwdzq3h6k6r5mn@shell.armlinux.org.uk> (raw)
In-Reply-To: <f002402d-fb27-f697-f07d-de3cdff41f40@infradead.org>
Hi Randy,
Sorry for the delay.
On Wed, Feb 13, 2019 at 08:00:29PM -0800, Randy Dunlap wrote:
> On 2/5/19 7:58 AM, Russell King wrote:
> > +uses in-band mode, where results from the PHYs negotiation are passed
>
> PHY's
...
> > + Manipulation of the PHY's supported/advertised happens within phylink
>
> PHYs
Either one way or the other. "negotiation of the PHY", "supported/
advertised (link modes) of the PHY". Both are posessive, so the first
is a mistake but I don't agree with removing the posessive apostrophy
in the second case.
> > +For information describing the SFP cage in DT, please see the binding
> > +documentation in the kernel source tree
> > +``Documentation/devicetree/bindings/net/sff,sfp.txt``
> oh, so SFP means "Small Form-factor Pluggable".
>
> I see that this source file:
> ./drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1902:
>
> seems to imply that SFP means "single function per port (SFP) mode":
>
> dev_err(&pf->pdev->dev,
> "VF %d requested polling mode: this feature is supported only when the device is running in single function per port (SFP) mode\n",
> vf->vf_id);
Software engineers endlessly like to create TLAs, so it could mean
both, but in this case it's the official definition from the SFF/
SNIA documents, e.g.:
INF-8074i Specification for
SFP (Small Formfactor Pluggable) Transceiver
note, no hyphen!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
prev parent reply other threads:[~2019-02-22 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 15:58 [PATCH 2/2] doc: add phylink documentation to the networking book Russell King
2019-02-06 1:59 ` Andrew Lunn
2019-02-14 4:00 ` Randy Dunlap
2019-02-14 4:32 ` Andrew Lunn
2019-02-14 4:39 ` Randy Dunlap
2019-02-22 11:20 ` Russell King - ARM Linux admin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222112033.odgwdzq3h6k6r5mn@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).