From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D57C43381 for ; Sun, 24 Feb 2019 02:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE81520663 for ; Sun, 24 Feb 2019 02:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728036AbfBXCer (ORCPT ); Sat, 23 Feb 2019 21:34:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:44806 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbfBXCer (ORCPT ); Sat, 23 Feb 2019 21:34:47 -0500 Received: from localhost (c-67-183-62-245.hsd1.wa.comcast.net [67.183.62.245]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5C5EF108DE858; Sat, 23 Feb 2019 18:34:46 -0800 (PST) Date: Sat, 23 Feb 2019 18:34:35 -0800 (PST) Message-Id: <20190223.183435.22949869818395441.davem@davemloft.net> To: cascardo@canonical.com Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, dsahern@gmail.com Subject: Re: [PATCH] selftests: fib_tests: sleep after changing carrier. again. From: David Miller In-Reply-To: <20190222102741.31173-1-cascardo@canonical.com> References: <20190222102741.31173-1-cascardo@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 23 Feb 2019 18:34:46 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Thadeu Lima de Souza Cascardo Date: Fri, 22 Feb 2019 07:27:41 -0300 > Just like commit e2ba732a1681 ("selftests: fib_tests: sleep after > changing carrier"), wait one second to allow linkwatch to propagate the > carrier change to the stack. > > There are two sets of carrier tests. The first slept after the carrier > was set to off, and when the second set ran, it was likely that the > linkwatch would be able to run again without much delay, reducing the > likelihood of a race. However, if you run 'fib_tests.sh -t carrier' on a > loop, you will quickly notice the failures. > > Sleeping on the second set of tests make the failures go away. > > Cc: David Ahern > Signed-off-by: Thadeu Lima de Souza Cascardo Applied, thanks.