From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D427C43381 for ; Mon, 25 Feb 2019 01:34:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A57A21019 for ; Mon, 25 Feb 2019 01:34:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728067AbfBYBeN (ORCPT ); Sun, 24 Feb 2019 20:34:13 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33480 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726461AbfBYBeN (ORCPT ); Sun, 24 Feb 2019 20:34:13 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6FBA414D6678D; Sun, 24 Feb 2019 17:34:12 -0800 (PST) Date: Sun, 24 Feb 2019 17:34:11 -0800 (PST) Message-Id: <20190224.173411.1851674211957686479.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next] net: phy: improve definition of __ETHTOOL_LINK_MODE_MASK_NBITS From: David Miller In-Reply-To: <3ae0478b-810f-904e-e128-7e0a57c7255c@gmail.com> References: <3ae0478b-810f-904e-e128-7e0a57c7255c@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 24 Feb 2019 17:34:12 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Fri, 22 Feb 2019 19:25:59 +0100 > The way to define __ETHTOOL_LINK_MODE_MASK_NBITS seems to be overly > complicated, go with a standard approach instead. > Whilst we're at it, move the comment to the right place. > > v2: > - rebased > > Signed-off-by: Heiner Kallweit Applied, thanks Heiner.