From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: davem@davemloft.net, mkubecek@suse.cz, andrew@lunn.ch,
f.fainelli@gmail.com, netdev@vger.kernel.org,
oss-drivers@netronome.com
Subject: Re: [PATCH net-next v3 1/6] net: devlink: turn devlink into a built-in
Date: Sun, 24 Feb 2019 11:46:43 +0100 [thread overview]
Message-ID: <20190224104643.GE2759@nanopsycho.orion> (raw)
In-Reply-To: <20190222220758.7117-2-jakub.kicinski@netronome.com>
Fri, Feb 22, 2019 at 11:07:52PM CET, jakub.kicinski@netronome.com wrote:
>Being able to build devlink as a module causes growing pains.
>First all drivers had to add a meta dependency to make sure
>they are not built in when devlink is built as a module. Now
>we are struggling to invoke ethtool compat code reliably.
>
>Make devlink code built-in, users can still not build it at
>all but the dynamically loadable module option is removed.
>
>Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2019-02-24 10:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 22:07 [PATCH net-next v3 0/6] devlink: make ethtool compat reliable Jakub Kicinski
2019-02-22 22:07 ` [PATCH net-next v3 1/6] net: devlink: turn devlink into a built-in Jakub Kicinski
2019-02-24 10:46 ` Jiri Pirko [this message]
2019-02-22 22:07 ` [PATCH net-next v3 2/6] devlink: create a special NDO for getting the devlink instance Jakub Kicinski
2019-02-24 10:51 ` Jiri Pirko
2019-02-22 22:07 ` [PATCH net-next v3 3/6] nfp: add .ndo_get_devlink Jakub Kicinski
2019-02-24 10:52 ` Jiri Pirko
2019-02-25 2:05 ` Florian Fainelli
2019-02-22 22:07 ` [PATCH net-next v3 4/6] nfp: remove ethtool flashing fallback Jakub Kicinski
2019-02-24 10:53 ` Jiri Pirko
2019-02-25 2:06 ` Florian Fainelli
2019-02-22 22:07 ` [PATCH net-next v3 5/6] devlink: hold a reference to the netdevice around ethtool compat Jakub Kicinski
2019-02-24 11:00 ` Jiri Pirko
2019-02-25 18:31 ` Jakub Kicinski
2019-02-26 3:07 ` Jakub Kicinski
2019-02-26 6:50 ` Jiri Pirko
2019-02-22 22:07 ` [PATCH net-next v3 6/6] devlink: add missing NULL checks for devlink ops Jakub Kicinski
2019-02-24 11:03 ` Jiri Pirko
2019-02-25 18:32 ` Jakub Kicinski
2019-02-26 6:50 ` Jiri Pirko
2019-02-25 1:43 ` [PATCH net-next v3 0/6] devlink: make ethtool compat reliable David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190224104643.GE2759@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).