From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BCB5C43381 for ; Mon, 25 Feb 2019 18:17:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A7FC20842 for ; Mon, 25 Feb 2019 18:17:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728862AbfBYSRD (ORCPT ); Mon, 25 Feb 2019 13:17:03 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:43304 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728816AbfBYSRD (ORCPT ); Mon, 25 Feb 2019 13:17:03 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2753214EE18D4; Mon, 25 Feb 2019 10:17:02 -0800 (PST) Date: Mon, 25 Feb 2019 10:16:59 -0800 (PST) Message-Id: <20190225.101659.79848785664331466.davem@davemloft.net> To: vladbu@mellanox.com Cc: netdev@vger.kernel.org, dcaratti@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, wenxu@ucloud.cn, roid@mellanox.com Subject: Re: [PATCH net] net: sched: act_tunnel_key: fix NULL pointer dereference during init From: David Miller In-Reply-To: <20190225152827.8741-1-vladbu@mellanox.com> References: <4bde1d403d4ba9b51cf18bbaac1d46147011b959.camel@redhat.com> <20190225152827.8741-1-vladbu@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Feb 2019 10:17:02 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov Date: Mon, 25 Feb 2019 17:28:27 +0200 > Metadata pointer is only initialized for action TCA_TUNNEL_KEY_ACT_SET, but > it is unconditionally dereferenced in tunnel_key_init() error handler. > Verify that metadata pointer is not NULL before dereferencing it in > tunnel_key_init error handling code. > > Fixes: ee28bb56ac5b ("net/sched: fix memory leak in act_tunnel_key_init()") > Signed-off-by: Vlad Buslov Applied and queued up for -stable.