From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 503B0C43381 for ; Mon, 25 Feb 2019 13:43:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 248B020842 for ; Mon, 25 Feb 2019 13:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727315AbfBYNnt (ORCPT ); Mon, 25 Feb 2019 08:43:49 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:60550 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726706AbfBYNnt (ORCPT ); Mon, 25 Feb 2019 08:43:49 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gyGXf-0007MI-TY; Mon, 25 Feb 2019 21:43:35 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gyGXa-0002wK-4O; Mon, 25 Feb 2019 21:43:30 +0800 Date: Mon, 25 Feb 2019 21:43:30 +0800 From: Herbert Xu To: Yue Haibing Cc: steffen.klassert@secunet.com, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] xfrm: correctly check policy index in verify_newpolicy_info Message-ID: <20190225134330.ohrvjssdnsmcyxnp@gondor.apana.org.au> References: <20190225095600.26260-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190225095600.26260-1-yuehaibing@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 25, 2019 at 05:56:00PM +0800, Yue Haibing wrote: > > the check. Then __xfrm_policy_unlink use the index to access array policy_count > whose size is XFRM_POLICY_MAX * 2, triggering out of bounds access. No it doesn't. Even if it did the bug would be in __xfrm_policy_unlink and not here. Your patch makes no sense. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt