From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF7BC43381 for ; Tue, 26 Feb 2019 17:00:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BD1720C01 for ; Tue, 26 Feb 2019 17:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551200408; bh=XMZijy0eEJZNdrwq6Eo1jWGaOpFy2ANVObQie2PQZhk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MTg6IJn5xc8VfKRpFefbqf6XwzmppdZb8eYPg5gTQtuNDsc6T9iOtdLaYyivjX2Yf /NS3cmbt3YnYro5C4R78L+XN9dftjFxvaDhLV0zywz56DQDketX2AmMGAp84KQOAnY wymBy6z2U2MU+wODu4YcO9NYPsvgLAQ8Ffdvw4gg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728070AbfBZRAG (ORCPT ); Tue, 26 Feb 2019 12:00:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:40770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727054AbfBZRAG (ORCPT ); Tue, 26 Feb 2019 12:00:06 -0500 Received: from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com [216.129.126.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE7712173C; Tue, 26 Feb 2019 17:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551200406; bh=XMZijy0eEJZNdrwq6Eo1jWGaOpFy2ANVObQie2PQZhk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b8ESSzfpkIFt498R4vR74syiC0crwy0nZDE5JMg+eMHLcHhcb2GAGE9hZryyfU2pL fqYA9ffPN/ceQ7EBNmnHdy757Hgg4ortGAxj9ljTwxsciFafTlGGp813IJ7jcyrEtf 1yj+sp8AO2Xb1UApYJ5Lbs9cSJ5IxK4YZKfr4x3I= From: David Ahern To: davem@davemloft.net Cc: netdev@vger.kernel.org, David Ahern Subject: [PATCH net 1/3] ipv4: Return error for RTA_VIA attribute Date: Tue, 26 Feb 2019 09:00:02 -0800 Message-Id: <20190226170004.4535-2-dsahern@kernel.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190226170004.4535-1-dsahern@kernel.org> References: <20190226170004.4535-1-dsahern@kernel.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern IPv4 currently does not support nexthops outside of the AF_INET family. Specifically, it does not handle RTA_VIA attribute. If it is passed in a route add request, the actual route added only uses the device which is clearly not what the user intended: $ ip ro add 172.16.1.0/24 via inet6 2001:db8:1::1 dev eth0 $ ip ro ls ... 172.16.1.0/24 dev eth0 Catch this and fail the route add: $ ip ro add 172.16.1.0/24 via inet6 2001:db8:1::1 dev eth0 Error: IPv4 does not support RTA_VIA attribute. Fixes: 03c0566542f4c ("mpls: Netlink commands to add, remove, and dump routes") Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index fe4f6a624238..ed14ec245584 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -710,6 +710,10 @@ static int rtm_to_fib_config(struct net *net, struct sk_buff *skb, case RTA_GATEWAY: cfg->fc_gw = nla_get_be32(attr); break; + case RTA_VIA: + NL_SET_ERR_MSG(extack, "IPv4 does not support RTA_VIA attribute"); + err = -EINVAL; + goto errout; case RTA_PRIORITY: cfg->fc_priority = nla_get_u32(attr); break; -- 2.11.0