From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBF9C43381 for ; Wed, 27 Feb 2019 17:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA33F20C01 for ; Wed, 27 Feb 2019 17:35:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729257AbfB0Rfl (ORCPT ); Wed, 27 Feb 2019 12:35:41 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:45890 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbfB0Rfl (ORCPT ); Wed, 27 Feb 2019 12:35:41 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 246A3107101E4; Wed, 27 Feb 2019 09:35:41 -0800 (PST) Date: Wed, 27 Feb 2019 09:35:40 -0800 (PST) Message-Id: <20190227.093540.950256217269958405.davem@davemloft.net> To: andriy.shevchenko@linux.intel.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH v1] enc28j60: Correct description of debug module parameter From: David Miller In-Reply-To: <20190227104535.15504-1-andriy.shevchenko@linux.intel.com> References: <20190227104535.15504-1-andriy.shevchenko@linux.intel.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 27 Feb 2019 09:35:41 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andy Shevchenko Date: Wed, 27 Feb 2019 13:45:35 +0300 > The netif_msg_init() API takes on input the amount of bits to be set. The > description of debug parameter in the enc28j60 module is misleading in this > sense and passing 0xffff does not give an expected behaviour. > > Fix the description of debug module parameter to show what exactly is expected. > > Signed-off-by: Andy Shevchenko Applied.