From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F95FC43381 for ; Wed, 27 Feb 2019 06:41:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 118E8218D0 for ; Wed, 27 Feb 2019 06:41:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="CeNHJjTJ"; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="Y8rXqz++" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729264AbfB0GlB (ORCPT ); Wed, 27 Feb 2019 01:41:01 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:38430 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728930AbfB0GlB (ORCPT ); Wed, 27 Feb 2019 01:41:01 -0500 Received: from pps.filterd (m0001255.ppops.net [127.0.0.1]) by mx0b-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1R6VxB0015449; Tue, 26 Feb 2019 22:40:39 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=xpXxhY0DABP0euBOvGpBxI565pWqiupJ4XOhT7Ksl0M=; b=CeNHJjTJz1WFDePcaIBSB1+F2I8gomzOs5X3RtIL6eB3r49x6I1+ukrYRl5mGUUWK+tB Skig6miiYlzlNgncWX9d6+mOn1flyliSimK0PImy0tHo+xD9EhUmQYrvHUFOvtjtKwOt lq8Q6inNvdjhJV7WNQtNQfah88FSDJxVoB4= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0b-00082601.pphosted.com with ESMTP id 2qwhevgjsm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 26 Feb 2019 22:40:39 -0800 Received: from prn-hub02.TheFacebook.com (2620:10d:c081:35::126) by prn-hub01.TheFacebook.com (2620:10d:c081:35::125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3; Tue, 26 Feb 2019 22:40:37 -0800 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3 via Frontend Transport; Tue, 26 Feb 2019 22:40:37 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xpXxhY0DABP0euBOvGpBxI565pWqiupJ4XOhT7Ksl0M=; b=Y8rXqz++eb13fUSiU9HPF2Llh3NqSrrFX6irVELkiWg9EspAbGQMOicpiH9TIBgpvMgxTXHDxYJtMRxj1wapInZEcvcpSjLB29jLxVZQtIvGiuQjHucT6KmpHYzg06HrPZyTsl2fINGe9F8Nd9IMabnyydG6UMO3dV6xGpyiaAE= Received: from MWHPR15MB1790.namprd15.prod.outlook.com (10.174.255.19) by MWHPR15MB1135.namprd15.prod.outlook.com (10.175.2.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.20; Wed, 27 Feb 2019 06:40:36 +0000 Received: from MWHPR15MB1790.namprd15.prod.outlook.com ([fe80::ac2f:bf87:54e:48a2]) by MWHPR15MB1790.namprd15.prod.outlook.com ([fe80::ac2f:bf87:54e:48a2%12]) with mapi id 15.20.1643.022; Wed, 27 Feb 2019 06:40:36 +0000 From: Martin Lau To: "Daniel T. Lee" CC: Daniel Borkmann , Alexei Starovoitov , "netdev@vger.kernel.org" Subject: Re: [PATCH] samples: bpf: fix: broken sample regarding removed function Thread-Topic: [PATCH] samples: bpf: fix: broken sample regarding removed function Thread-Index: AQHUzklujVUlf1Ulf0ScEWeWn9EuWKXzMhqA Date: Wed, 27 Feb 2019 06:40:36 +0000 Message-ID: <20190227064033.sylc3gsvvlugctgq@kafai-mbp.dhcp.thefacebook.com> References: <20190227030559.19672-1-danieltimlee@gmail.com> In-Reply-To: <20190227030559.19672-1-danieltimlee@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR05CA0057.namprd05.prod.outlook.com (2603:10b6:a03:74::34) To MWHPR15MB1790.namprd15.prod.outlook.com (2603:10b6:301:4e::19) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [2620:10d:c090:180::1:a3a6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 91098731-b301-486f-6387-08d69c7e7aa0 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:MWHPR15MB1135; x-ms-traffictypediagnostic: MWHPR15MB1135: x-microsoft-exchange-diagnostics: 1;MWHPR15MB1135;20:ghDPjhNeopaMu40VXcDtQq3Y0+C5Ix8SJXKm1X9xtq5p/5F8D4xwgc+rkRwuoG9J+jNAHKQiJpDcbr+sziFYr4r/ubzqwqzGeX2zQL4VZ04yfHP+Y3yoNfvzNz8QIPo9W8JQdHMPM4iuZM8loS1JRMT65i6lxUG7GyvJ2H+Xhy0= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(376002)(396003)(136003)(366004)(346002)(199004)(189003)(6486002)(229853002)(2906002)(8936002)(25786009)(6246003)(305945005)(486006)(97736004)(76176011)(478600001)(52116002)(105586002)(106356001)(71190400001)(71200400001)(14454004)(86362001)(6436002)(4326008)(7736002)(81156014)(8676002)(81166006)(53936002)(6512007)(9686003)(5660300002)(256004)(14444005)(54906003)(99286004)(316002)(6916009)(68736007)(1076003)(46003)(476003)(11346002)(6116002)(186003)(102836004)(1411001)(386003)(446003)(6506007);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1135;H:MWHPR15MB1790.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: w628RM4aV9inD8r5k8qWfQerqgEnMZ42KjMqlE3QnPJsNhItIjShx/H2SJ/cadX1e00Lz1wfyLV7+GWDayVL3SCIJ6ROX5T17oD0NE0JbnR9y/bMeYzWOVBg6+yop2DFmuiY5VuC/2e6Z3KV7f41fIYOSi/x0zj3Xbpx54hNFgKxyAULhozDHLqElKQaGBggUR76VCGU/HtDLU6JJ+u73blftY13MWpyYnwpkq98MO0fOmvX6Edc9VsRiyLq6P63zaAadNfmkrQQpZVczmfGPTW1CtzN9eshLZD9vkOjV+fIMOUIhHg2LtFHz+AFGtOSpBl3oCfV6Nc1aSj1+ZtjnggFhtjQVkNSWfhlNif2pkSGuy0XRS8fQAs43qdpyyhLChocNxmnOFSXU9k0RtPjLeFTF92KsRv2Hhx9qFGPzmw= Content-Type: text/plain; charset="us-ascii" Content-ID: <2A1C4AD39049DF4285A14D8F8702F407@namprd15.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 91098731-b301-486f-6387-08d69c7e7aa0 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 06:40:35.1093 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1135 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-27_05:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 26, 2019 at 10:05:59PM -0500, Daniel T. Lee wrote: > Currently, running sample "task_fd_query" and "tracex3" occurs the > following error. On kernel v5.0-rc* this sample will be unavailable > due to the removal of function 'blk_start_request' at commit "a1ce35f". > (function removed, as "Single Queue IO scheduler" no longer exists) >=20 > $ sudo ./task_fd_query > failed to create kprobe 'blk_start_request' error 'No such file or > directory' >=20 > This commit will change the function 'blk_start_request' to > 'blk_mq_start_request' to fix the broken sample. >=20 > Signed-off-by: Daniel T. Lee > --- > samples/bpf/task_fd_query_kern.c | 2 +- > samples/bpf/task_fd_query_user.c | 2 +- > samples/bpf/tracex3_kern.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/samples/bpf/task_fd_query_kern.c b/samples/bpf/task_fd_query= _kern.c > index f4b0a9ea674d..5f1b2cdababd 100644 > --- a/samples/bpf/task_fd_query_kern.c > +++ b/samples/bpf/task_fd_query_kern.c > @@ -4,7 +4,7 @@ > #include > #include "bpf_helpers.h" > =20 > -SEC("kprobe/blk_start_request") > +SEC("kprobe/blk_mq_start_requset") I suspect it does not run. Have you tested it? There is a typo: blk_mq_start_requSEt blk_mq_start_requESt