netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Tristram.Ha@microchip.com
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Pavel Machek <pavel@ucw.cz>,
	UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: dsa: document additional Microchip KSZ9477 family switches
Date: Wed, 27 Feb 2019 13:41:12 +0100	[thread overview]
Message-ID: <20190227124112.GG3809@lunn.ch> (raw)
In-Reply-To: <1551224265-9304-2-git-send-email-Tristram.Ha@microchip.com>

On Tue, Feb 26, 2019 at 03:37:43PM -0800, Tristram.Ha@microchip.com wrote:
> +				port@3 {
> +					reg = <3>;
> +					label = "lan4";
> +				};
> +				port@4 {
> +					reg = <6>;

Hi Tristram

The number after the @ must be the same as the register. So this needs
to be port@6.

   Andrew

> +					label = "cpu";
> +					ethernet = <&eth0>;
> +					fixed-link {
> +						speed = <1000>;
> +						full-duplex;
> +					};
> +				};
> +			};
> +		};
>  	};
> -- 
> 1.9.1
> 

  reply	other threads:[~2019-02-27 12:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 23:37 [PATCH net-next 0/3] net: dsa: microchip: add KSZ9893 switch support Tristram.Ha
2019-02-26 23:37 ` [PATCH net-next 1/3] dt-bindings: net: dsa: document additional Microchip KSZ9477 family switches Tristram.Ha
2019-02-27 12:41   ` Andrew Lunn [this message]
2019-02-26 23:37 ` [PATCH net-next 2/3] net: dsa: microchip: add KSZ9893 switch support Tristram.Ha
2019-02-27 13:14   ` Andrew Lunn
2019-02-26 23:37 ` [PATCH net-next 3/3] net: dsa: microchip: add other KSZ9477 switch variants Tristram.Ha
2019-02-27  6:47   ` kbuild test robot
2019-02-27 13:23   ` Andrew Lunn
2019-02-27 13:33   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190227124112.GG3809@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Tristram.Ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).