From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5FBEC43381 for ; Thu, 28 Feb 2019 23:32:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87CF120830 for ; Thu, 28 Feb 2019 23:32:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="VVBTr2iY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731797AbfB1XcO (ORCPT ); Thu, 28 Feb 2019 18:32:14 -0500 Received: from mx3.wp.pl ([212.77.101.9]:26220 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729133AbfB1XcO (ORCPT ); Thu, 28 Feb 2019 18:32:14 -0500 Received: (wp-smtpd smtp.wp.pl 32691 invoked from network); 1 Mar 2019 00:32:10 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1551396730; bh=W10EVViwFiR8s6tvahd4WAsmvwnxAk7wDRBqLEpiBIc=; h=From:To:Cc:Subject; b=VVBTr2iYmBgqD+1dG+d7xihv/pG6SFB48PQVIw35wAZXKm7s+Gqp2ZZbS837/O+yg q7qdJmEiZwezQMZTIjIK6dDR/tIkj/lW2AFfTE1yW8k7Vf7t1Bqj+hu1GGQajVk2nT D1pvs3nO7RHN3d88dquXA5TXhajKkYX8VOcl22is= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 1 Mar 2019 00:32:10 +0100 Date: Thu, 28 Feb 2019 15:31:56 -0800 From: Jakub Kicinski To: "Michael S. Tsirkin" Cc: si-wei liu , "Samudrala, Sridhar" , Siwei Liu , Jiri Pirko , Stephen Hemminger , David Miller , Netdev , virtualization@lists.linux-foundation.org, "Brandeburg, Jesse" , Alexander Duyck , Jason Wang , liran.alon@oracle.com Subject: Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) Message-ID: <20190228153156.418525fc@cakuba.netronome.com> In-Reply-To: <20190228151349-mutt-send-email-mst@kernel.org> References: <20190227184601-mutt-send-email-mst@kernel.org> <20190227193923-mutt-send-email-mst@kernel.org> <20190227165205.307ed83c@cakuba.netronome.com> <20190227201857-mutt-send-email-mst@kernel.org> <20190227175218.736e13b6@cakuba.netronome.com> <20190227233812-mutt-send-email-mst@kernel.org> <20190228101356.39ac70aa@cakuba.netronome.com> <20190228143511-mutt-send-email-mst@kernel.org> <20190228115641.7afe6f09@cakuba.netronome.com> <20190228151349-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: c7724110382b21ae07997360f77183ce X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [wVNE] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 28 Feb 2019 15:14:55 -0500, Michael S. Tsirkin wrote: > On Thu, Feb 28, 2019 at 11:56:41AM -0800, Jakub Kicinski wrote: > > On Thu, 28 Feb 2019 14:36:56 -0500, Michael S. Tsirkin wrote: > > > > It is a bit of a the chicken or the egg situation ;) But users can > > > > just blacklist, too. Anyway, I think this is far better than module > > > > parameters > > > > > > Sorry I'm a bit confused. What is better than what? > > > > I mean that blacklist net_failover or module param to disable > > net_failover and handle in user space are better than trying to solve > > the renaming at kernel level (either by adding module params that make > > the kernel rename devices or letting user space change names of running > > devices if they are slaves). > > > > > > for twiddling kernel-based interface naming policy.. :S > > > > > > I see your point. But my point is slave names don't really matter, only > > > master name matters. So I am not sure there's any policy worth talking > > > about here. > > > > Oh yes, I don't disagree with you, but others seems to want to rename > > the auto-bonded lower devices. Which can be done trivially if it was > > a daemon in user space instantiating the auto-bond. We are just > > providing a basic version of auto-bonding in the kernel. If there are > > extra requirements on policy, or naming - the whole thing is better > > solved in user space. > > OK so it seems that you would be happy with a combination of the module > parameter disabling failover completely and renaming primary in kernel? > Did I get it right? Not 100%, I'm personally not convinced that renaming primary in the kernel is okay.