From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D59C43381 for ; Fri, 1 Mar 2019 19:24:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CCFD2084F for ; Fri, 1 Mar 2019 19:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726038AbfCATYU (ORCPT ); Fri, 1 Mar 2019 14:24:20 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56596 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfCATYU (ORCPT ); Fri, 1 Mar 2019 14:24:20 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BA0E514F6CEE6; Fri, 1 Mar 2019 11:24:19 -0800 (PST) Date: Fri, 01 Mar 2019 11:24:19 -0800 (PST) Message-Id: <20190301.112419.1191774943249107657.davem@davemloft.net> To: pabeni@redhat.com Cc: netdev@vger.kernel.org, willemb@google.com Subject: Re: [PATCH net] selftests: fixes for UDP GRO From: David Miller In-Reply-To: <2b1f4d9fe21346bc9f85c096e1b0922e4ff3c19d.1551173111.git.pabeni@redhat.com> References: <2b1f4d9fe21346bc9f85c096e1b0922e4ff3c19d.1551173111.git.pabeni@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 01 Mar 2019 11:24:19 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Paolo Abeni Date: Tue, 26 Feb 2019 15:27:43 +0100 > The current implementation for UDP GRO tests is racy: the receiver > may flush the RX queue while the sending is still transmitting and > incorrectly report RX errors, with a wrong number of packet received. > > Add explicit timeouts to the receiver for both connection activation > (first packet received for UDP) and reception completion, so that > in the above critical scenario the receiver will wait for the > transfer completion. > > Fixes: 3327a9c46352 ("selftests: add functionals test for UDP GRO") > Signed-off-by: Paolo Abeni Applied, thanks Paolo.