From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464F4C43381 for ; Sat, 2 Mar 2019 00:42:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07D5720823 for ; Sat, 2 Mar 2019 00:42:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726403AbfCBAmi (ORCPT ); Fri, 1 Mar 2019 19:42:38 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:60650 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbfCBAmh (ORCPT ); Fri, 1 Mar 2019 19:42:37 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F2D1313E92723; Fri, 1 Mar 2019 16:42:36 -0800 (PST) Date: Fri, 01 Mar 2019 16:42:34 -0800 (PST) Message-Id: <20190301.164234.33116600327008363.davem@davemloft.net> To: liuhangbin@gmail.com Cc: netdev@vger.kernel.org, dsahern@gmail.com, roopa@cumulusnetworks.com, sd@queasysnail.net Subject: Re: [PATCH v2 net] ipv4: Add ICMPv6 support when parse route ipproto From: David Miller In-Reply-To: <20190227081529.23657-1-liuhangbin@gmail.com> References: <20190225074700.7316-1-liuhangbin@gmail.com> <20190227081529.23657-1-liuhangbin@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 01 Mar 2019 16:42:37 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Hangbin Liu Date: Wed, 27 Feb 2019 16:15:29 +0800 > For ip rules, we need to use 'ipproto ipv6-icmp' to match ICMPv6 headers. > But for ip -6 route, currently we only support tcp, udp and icmp. > > Add ICMPv6 support so we can match ipv6-icmp rules for route lookup. > > v2: As David Ahern and Sabrina Dubroca suggested, Add an argument to > rtm_getroute_parse_ip_proto() to handle ICMP/ICMPv6 with different family. > > Reported-by: Jianlin Shi > Fixes: eacb9384a3fe ("ipv6: support sport, dport and ip_proto in RTM_GETROUTE") > Signed-off-by: Hangbin Liu Applied and queued up for -stable, thanks.