Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: Arthur Fabre <afabre@cloudflare.com>
To: marek@cloudflare.com
Cc: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
	afabre@cloudflare.com
Subject: RE: SOCKET_FILTER regression - eBPF can't subtract when attached from unprivileged user
Date: Fri,  1 Mar 2019 11:39:01 +0000
Message-ID: <20190301113901.29448-1-afabre@cloudflare.com> (raw)
In-Reply-To: <CAJPywTJqP34cK20iLM5YmUMz9KXQOdu1-+BZrGMAGgLuBWz7fg@mail.gmail.com>

I can reproduce this on 4.19.0-3-amd64 both with, and without the JIT enabled.

Dumping the "root" and "non-root" programs with bpftool,
the subtraction instructions differ:

"non-root":
   0: (85) call bpf_ktime_get_ns#74944
   1: (bf) r7 = r0
   2: (85) call bpf_ktime_get_ns#74944
   3: (bf) r6 = r0
   4: (bf) r8 = r6
   5: (b4) w11 = -1
   6: (1f) r11 -= r8
   7: (4f) r11 |= r8
   8: (87) r11 = -r11
   9: (c7) r11 s>>= 63
  10: (5f) r8 &= r11

"root":
   0: (85) call bpf_ktime_get_ns#74944
   1: (bf) r7 = r0
   2: (85) call bpf_ktime_get_ns#74944
   3: (bf) r6 = r0
   4: (bf) r8 = r6

The remainder of the instructions are for writing the results in the map,
and the instructions are identical.

I believe the extra instructions come from "fixup_bpf_calls" in the verifier:

    if (isneg)
        *patch++ = BPF_ALU64_IMM(BPF_MUL, off_reg, -1);
    *patch++ = BPF_MOV32_IMM(BPF_REG_AX, aux->alu_limit - 1);
    *patch++ = BPF_ALU64_REG(BPF_SUB, BPF_REG_AX, off_reg);
    *patch++ = BPF_ALU64_REG(BPF_OR, BPF_REG_AX, off_reg);
    *patch++ = BPF_ALU64_IMM(BPF_NEG, BPF_REG_AX, 0);
    *patch++ = BPF_ALU64_IMM(BPF_ARSH, BPF_REG_AX, 63);
    if (issrc) {
        *patch++ = BPF_ALU64_REG(BPF_AND, BPF_REG_AX,
                     off_reg);
        insn->src_reg = BPF_REG_AX;
    } else {
        *patch++ = BPF_ALU64_REG(BPF_AND, off_reg,
                     BPF_REG_AX);
    }

This was introduced by "bpf: prevent out of bounds speculation on pointer arithmetic"
(https://patchwork.ozlabs.org/patch/1039606/).
I don't yet understand what's going on.

Cheers,

Arthur

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01  1:06 Marek Majkowski
2019-03-01 11:39 ` Arthur Fabre [this message]
2019-03-01 12:51   ` Daniel Borkmann
2019-03-01 14:04   ` Daniel Borkmann
2019-03-01 14:10     ` Marek Majkowski
2019-03-01 14:22       ` Daniel Borkmann

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190301113901.29448-1-afabre@cloudflare.com \
    --to=afabre@cloudflare.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=marek@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox