From: Vinod Koul <vkoul@kernel.org>
To: xiaofeis@codeaurora.org
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Niklas Cassel <niklas.cassel@linaro.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: read mac address from DT for slave device
Date: Mon, 4 Mar 2019 13:01:22 +0530 [thread overview]
Message-ID: <20190304073122.GA2598@vkoul-mobl> (raw)
In-Reply-To: <d99a07c116b4bd042d9cc8377015970b@codeaurora.org>
On 04-03-19, 11:46, xiaofeis@codeaurora.org wrote:
> On 2019-02-22 22:26, Andrew Lunn wrote:
> > On Fri, Feb 22, 2019 at 06:28:15PM +0530, Vinod Koul wrote:
> > > From: Xiaofei Shen <xiaofeis@codeaurora.org>
> > >
> > > Before creating a slave netdevice, get the mac address from DTS and
> > > apply in case it is valid.
> > >
> > > Signed-off-by: Xiaofei Shen <xiaofeis@codeaurora.org>
> > > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> >
> > Hi Xiaofei, Vinod
> >
> > It would be good to document this in the binding.
> >
> > Andrew
>
> From 4c8597161975dbef5fbe814aeee93599b4c57d37 Mon Sep 17 00:00:00 2001
> From: xiaofeis <xiaofeis@codeaurora.org>
> Date: Fri, 1 Mar 2019 13:54:52 +0800
> Subject: [PATCH] net: dsa: Add support for port mac address
>
> Allow port network device's mac address to be retrieved from the
> device tree.
>
> Signed-off-by: xiaofeis <xiaofeis@codeaurora.org>
> ---
> Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt
> b/Documentation/devicetree/bindings/net/dsa/dsa.txt
> index cfe8f64..1816f82 100644
> --- a/Documentation/devicetree/bindings/net/dsa/dsa.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/dsa.txt
> @@ -71,6 +71,10 @@ properties, described in binding documents:
> Documentation/devicetree/bindings/net/fixed-link.txt
> for details.
>
> +- local-mac-address : See
> + Documentation/devicetree/bindings/net/ethernet.txt
> + for details.
> +
Can you send this as independent patch to Dave and cc netdev and others
on this thread. This looks good to me so feel free to add
Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Example
>
> The following example shows three switches on three MDIO busses,
> @@ -99,6 +103,7 @@ linked into one DSA cluster.
> port@1 {
> reg = <1>;
> label = "lan1";
> + local-mac-address = [000000000001];
> };
>
> port@2 {
--
~Vinod
next prev parent reply other threads:[~2019-03-04 7:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 12:58 [PATCH] net: dsa: read mac address from DT for slave device Vinod Koul
2019-02-22 14:26 ` Andrew Lunn
2019-03-04 3:46 ` xiaofeis
2019-03-04 7:31 ` Vinod Koul [this message]
2019-03-04 13:18 ` Andrew Lunn
2019-02-22 15:43 ` Florian Fainelli
2019-02-25 13:28 ` xiaofeis
2019-02-25 17:27 ` Florian Fainelli
2019-02-26 7:45 ` xiaofeis
2019-02-27 2:04 ` xiaofeis
2019-02-27 3:13 ` Florian Fainelli
2019-02-28 2:23 ` xiaofeis
2019-02-28 3:54 ` Florian Fainelli
2019-03-04 3:48 ` xiaofeis
2019-03-27 3:56 ` xiaofeis
2019-02-27 6:57 ` xiaofeis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304073122.GA2598@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=vivien.didelot@gmail.com \
--cc=xiaofeis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).