From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58080C43381 for ; Fri, 8 Mar 2019 16:04:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 232BA20868 for ; Fri, 8 Mar 2019 16:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbfCHQE4 (ORCPT ); Fri, 8 Mar 2019 11:04:56 -0500 Received: from mail.us.es ([193.147.175.20]:55854 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbfCHQEq (ORCPT ); Fri, 8 Mar 2019 11:04:46 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id CC7A95E539A for ; Fri, 8 Mar 2019 17:04:44 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id BBD04DA864 for ; Fri, 8 Mar 2019 17:04:44 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 92F63DA867; Fri, 8 Mar 2019 17:04:44 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9C5D6DA844; Fri, 8 Mar 2019 17:04:42 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 08 Mar 2019 17:04:42 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 6BEF04265A4C; Fri, 8 Mar 2019 17:04:42 +0100 (CET) Date: Fri, 8 Mar 2019 17:04:41 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , =?iso-8859-1?Q?M=E1t=E9?= Eckl , Fernando Fernandez Mancera , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alin.nastac@gmail.com Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency Message-ID: <20190308160441.ler2hs44oaozoq7w@salvia> References: <20190304204019.2142770-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190304204019.2142770-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org hi Arnd, Cc'ing Alin Nastac. On Mon, Mar 04, 2019 at 09:40:12PM +0100, Arnd Bergmann wrote: > With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure: > > net/netfilter/nf_conntrack_sip.o: In function `process_sdp': > nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags' I see. We can probably use nf_route() instead. Or if needed, use struct nf_ipv6_ops for this. if (v6ops) ret = v6ops->route_xyz(...); @Alin: Would you send us a patch to do so to fix a3419ce3356cf1f netfilter: nf_conntrack_sip: add sip_external_media logic". This direct dependency with IPv6 is superfluous, it should not happen. Thanks!