From: David Miller <davem@davemloft.net>
To: sergei.shtylyov@cogentembedded.com
Cc: kjlu@umn.edu, pakki001@umn.edu, vladimir_zapolskiy@mentor.com,
geert+renesas@glider.be, horms+renesas@verge.net.au,
chris.brandt@renesas.com, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: renesas: fix a missing check of of_get_phy_mode
Date: Mon, 11 Mar 2019 10:52:03 -0700 (PDT) [thread overview]
Message-ID: <20190311.105203.2225467966650056784.davem@davemloft.net> (raw)
In-Reply-To: <20c5cfde-3c2d-43cb-efc4-be9782b7eb2e@cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Mon, 11 Mar 2019 13:29:10 +0300
> Hello!
>
> On 03/11/2019 10:49 AM, Kangjie Lu wrote:
>
>> of_get_phy_mode may fail and return a negative error code;
>> the fix checks the return value of of_get_phy_mode and
>> returns NULL of it fails.
>
> Sorry, I overlooked this issue.
>
>> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
>
> Fixes: b356e978e92f ("sh_eth: add device tree support")
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>> ---
>> drivers/net/ethernet/renesas/sh_eth.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Why are you not fixing ravb_main.c as well? Especially as you have "renesas:"
> in your subject, not "sh_eth:"? :-/
Kangjie please fix the subject line and incorporate Sergei's Fixes and
Reviewed-by tags.
Thanks.
next prev parent reply other threads:[~2019-03-11 17:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 7:49 [PATCH v2] net: renesas: fix a missing check of of_get_phy_mode Kangjie Lu
2019-03-11 10:29 ` Sergei Shtylyov
2019-03-11 17:52 ` David Miller [this message]
2019-03-11 17:55 ` Sergei Shtylyov
2019-03-12 6:30 ` [PATCH v2] net: sh_eth: " Kangjie Lu
2019-03-12 7:31 ` Sergei Shtylyov
2019-03-12 7:43 ` [PATCH v3] " Kangjie Lu
2019-03-12 7:50 ` Sergei Shtylyov
2019-03-12 8:18 ` Geert Uytterhoeven
2019-03-12 21:51 ` David Miller
2019-03-11 10:59 ` [PATCH v2] net: renesas: " Geert Uytterhoeven
2019-03-11 14:18 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311.105203.2225467966650056784.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).