From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EFCCC43381 for ; Fri, 15 Mar 2019 05:49:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69067218A5 for ; Fri, 15 Mar 2019 05:49:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728281AbfCOFtn (ORCPT ); Fri, 15 Mar 2019 01:49:43 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:51846 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727151AbfCOFtn (ORCPT ); Fri, 15 Mar 2019 01:49:43 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1h4fiq-0006sG-EB; Fri, 15 Mar 2019 13:49:36 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1h4fiq-0000Ws-7m; Fri, 15 Mar 2019 13:49:36 +0800 Date: Fri, 15 Mar 2019 13:49:36 +0800 From: Herbert Xu To: NeilBrown Cc: Thomas Graf , netdev@vger.kernel.org, "Paul E. McKenney" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] rhashtable: rename rht_for_each*continue as *from. Message-ID: <20190315054936.hegjwrwkzdig772c@gondor.apana.org.au> References: <155253979234.5022.1840929790507376038.stgit@noble.brown> <155253992833.5022.6459847129731180970.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155253992833.5022.6459847129731180970.stgit@noble.brown> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 14, 2019 at 04:05:28PM +1100, NeilBrown wrote: > The pattern set by list.h is that for_each..continue() > iterators start at the next entry after the given one, > while for_each..from() iterators start at the given > entry. > > The rht_for_each*continue() iterators are documented as though the > start at the 'next' entry, but actually start at the given entry, > and they are used expecting that behaviour. > So fix the documentation and change the names to *from for consistency > with list.h > > Signed-off-by: NeilBrown > --- > .clang-format | 8 ++++---- > include/linux/rhashtable.h | 40 ++++++++++++++++++++-------------------- > lib/rhashtable.c | 2 +- > 3 files changed, 25 insertions(+), 25 deletions(-) Acked-by: Herbert Xu Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt