From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1433C43381 for ; Thu, 21 Mar 2019 14:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE8E3218D3 for ; Thu, 21 Mar 2019 14:15:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Sk8ps3Qh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728069AbfCUOPZ (ORCPT ); Thu, 21 Mar 2019 10:15:25 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36238 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727823AbfCUOPY (ORCPT ); Thu, 21 Mar 2019 10:15:24 -0400 Received: by mail-wr1-f65.google.com with SMTP id y13so6810459wrd.3 for ; Thu, 21 Mar 2019 07:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LLsAAoIq5ZSXmSL5griz1CAJaydmL/GMsf0qoirsNpQ=; b=Sk8ps3Qh++Gydk+Aay9LEwI83halhymmWCzGxlKUh45DsGgpNEhXxTh9sLDdaWGc1+ Na73zKWScFVH/NvRl/c0zidlEUW8BsDidVeweybri1SAm/o8fAKkmh6UM082HRutJZfW Wm+BSq9FRsuHFz+c+fGIRdIAMQgZX6IPaSeD1uDC75y8tTkLvlbEDHdmBMAc4AowUoNS CtvmzZhugHmLLVuxXcCh7f+zrUVfEW1rz2aotoCLqRMQQ0rekhQc3pBO/N7VxGR0jPnF tobLcGpAaINrFdsDTpTjz7sD7vLedZXcBkd5SHv1lBxvWuwL/LMhEatnuq8mWMkaRh0E Qe7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LLsAAoIq5ZSXmSL5griz1CAJaydmL/GMsf0qoirsNpQ=; b=c16rno62ThO72t3l8lBWDzg7oN6f6XuOkalHYChCRqvsowFhqPXmu7AUuTJ9Obty3F VbaK634iyQk1XI+z+NVSgHJG7ZiWDLrFcb9FtVg3B9dsInd+1y2no0ld1W2E3xE5VzG3 wu36FV/dkPmCBLh8U7sQ5o3u96r81gOj6VGyf/A6rr6FBOZkJJxmDJQpWrPR+41kg/f/ lsNfY6K3nsHqtUrsoZ36Mzca0WSsDqeoA757qOeUusJc718t+mYSpOI7Ta3tvYr7DeDG KCiAXHIf51yuRx5B4jWmFCU8WBeqfRO9DYDzclfmTQ7Bep7QfB961Woc/6uJ92wF+Vsp 1b9g== X-Gm-Message-State: APjAAAWPYGdszmIO2xrHG7U7YjJc1UjnoL1yQR/cakHsmlXIZBvPAZ8p lYSwpnqT/TtBi1SAGFDAvsHeGQ== X-Google-Smtp-Source: APXvYqxwQPXCi31uWyK+vyVr8KsgNi/bjKGy2UJphqfUxB5lgZfpcUcnPpbk8WOcwLDkS1s3dVhNwA== X-Received: by 2002:adf:d081:: with SMTP id y1mr2720972wrh.283.1553177722919; Thu, 21 Mar 2019 07:15:22 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id a82sm5759431wmf.11.2019.03.21.07.15.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 07:15:22 -0700 (PDT) Date: Thu, 21 Mar 2019 15:04:42 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, sbrivio@redhat.com Subject: Re: [PATCH net-next v3 04/12] net: sched: flower: track filter deletion with flag Message-ID: <20190321140442.GL2087@nanopsycho> References: <20190321131744.19224-1-vladbu@mellanox.com> <20190321131744.19224-5-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321131744.19224-5-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Mar 21, 2019 at 02:17:36PM CET, vladbu@mellanox.com wrote: >In order to prevent double deletion of filter by concurrent tasks when rtnl >lock is not used for synchronization, add 'deleted' filter field. Check >value of this field when modifying filters and return error if concurrent >deletion is detected. > >Refactor __fl_delete() to accept pointer to 'last' boolean as argument, >and return error code as function return value instead. This is necessary >to signal concurrent filter delete to caller. > >Signed-off-by: Vlad Buslov >Reviewed-by: Stefano Brivio Acked-by: Jiri Pirko