From: Neil Horman <nhorman@tuxdriver.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Matteo Croce <mcroce@redhat.com>,
Vladis Dronov <vdronov@redhat.com>
Subject: Re: [PATCH net-next 0/2] sctp: fully support memory accounting
Date: Tue, 2 Apr 2019 07:41:23 -0400 [thread overview]
Message-ID: <20190402114123.GB17593@hmswarspite.think-freely.org> (raw)
In-Reply-To: <20190402033610.GO16876@localhost.localdomain>
On Tue, Apr 02, 2019 at 12:36:10AM -0300, Marcelo Ricardo Leitner wrote:
> On Mon, Apr 01, 2019 at 07:31:10AM -0400, Neil Horman wrote:
> > On Sun, Mar 31, 2019 at 04:53:45PM +0800, Xin Long wrote:
> > > sctp memory accounting is added in this patchset by using
> > > these kernel APIs on send side:
> > >
> > > - sk_mem_charge()
> > > - sk_mem_uncharge()
> > > - sk_wmem_schedule()
> > > - sk_under_memory_pressure()
> > > - sk_mem_reclaim()
> > >
> > > and these on receive side:
> > >
> > > - sk_mem_charge()
> > > - sk_mem_uncharge()
> > > - sk_rmem_schedule()
> > > - sk_under_memory_pressure()
> > > - sk_mem_reclaim()
> > >
> > > With sctp memory accounting, we can limit the memory allocation by
> > > either sysctl:
> > >
> > > # sysctl -w net.sctp.sctp_mem="10 20 50"
> > >
> > > or cgroup:
> > >
> > > # echo $((8<<14)) > \
> > > /sys/fs/cgroup/memory/sctp_mem/memory.kmem.tcp.limit_in_bytes
> > >
> > > When the socket is under memory pressure, the send side will block
> > > and wait, while the receive side will renege or drop.
> > >
> > > Xin Long (2):
> > > sctp: implement memory accounting on tx path
> > > sctp: implement memory accounting on rx path
> > >
> > > include/net/sctp/sctp.h | 2 +-
> > > net/sctp/sm_statefuns.c | 6 ++++--
> > > net/sctp/socket.c | 10 ++++++++--
> > > net/sctp/ulpevent.c | 19 ++++++++-----------
> > > net/sctp/ulpqueue.c | 3 ++-
> > > 5 files changed, 23 insertions(+), 17 deletions(-)
> > >
> > > --
> > > 2.1.0
> > >
> > >
> > I don't have a problem with either of these patches in terms of altering memory
> > accounting, but SCTP has the notion of accounting buffers based on either
> > sockets space or association space (based on the sndbuf_policy and rcvbuf_policy
> > sysctls). This patch eliminates them. I don't see this patch addressing either
> > the removal of that functionality (as the proposed accounting scheme renders
> > those sysctls useless and ignored, which may cause regressions in some
> > environments), nor does it address the possibiliy of one association starving
> > others on the same socket when they share the same socket level accounting. I
> > think you need to look how to address that (either by re-adding the ability to
> > account in either case based on the sysctls, or deprecating eliminating the
> > sysctls and addressing the starvation issue.
>
> That's not how I'm reading these. All original conditions are still
> there while these patches are adding a couple of restrictions more.
> What that means is that they are adding a ceiling to it, even if the
> limits are per socket or per assoc. Considering the idea of the cgroup
> limit being added here, it makes sense to me. If the cgroup is
> configured to allow at most X MB, it doesn't matter how that is
> allocated. That's a sysadmin task then, to adjust the other sysctls
> (net.sctp.sctp_mem & cia) and balance the usage, be it per socket or
> per asoc.
>
You're right, I had the sense on the conditional backwards in my head. My bad
Series
Acked-by: Neil Horman <nhorman@tuxdriver.com>
prev parent reply other threads:[~2019-04-02 11:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 8:53 [PATCH net-next 0/2] sctp: fully support memory accounting Xin Long
2019-03-31 8:53 ` [PATCH net-next 1/2] sctp: implement memory accounting on tx path Xin Long
2019-03-31 8:53 ` [PATCH net-next 2/2] sctp: implement memory accounting on rx path Xin Long
2019-04-02 11:48 ` Marcelo Ricardo Leitner
2019-04-02 11:48 ` [PATCH net-next 1/2] sctp: implement memory accounting on tx path Marcelo Ricardo Leitner
2019-03-31 8:56 ` [PATCH net-next 0/2] sctp: fully support memory accounting Xin Long
2019-03-31 18:02 ` David Miller
2019-04-04 9:45 ` Xin Long
2019-04-04 17:38 ` David Miller
2019-04-05 4:49 ` Xin Long
2019-03-31 19:22 ` Matteo Croce
2019-03-31 20:10 ` Marcelo Ricardo Leitner
2019-03-31 21:04 ` David Miller
2019-04-01 7:25 ` Xin Long
2019-04-01 11:31 ` Neil Horman
2019-04-02 3:36 ` Marcelo Ricardo Leitner
2019-04-02 11:41 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402114123.GB17593@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).