From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDCB6C282DA for ; Wed, 17 Apr 2019 15:43:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88613205F4 for ; Wed, 17 Apr 2019 15:43:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LU4h1uVP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732670AbfDQPnM (ORCPT ); Wed, 17 Apr 2019 11:43:12 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:34471 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731454AbfDQPnM (ORCPT ); Wed, 17 Apr 2019 11:43:12 -0400 Received: by mail-pg1-f193.google.com with SMTP id v12so12202964pgq.1 for ; Wed, 17 Apr 2019 08:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=H/QZA3qmfHupeayn4HfaEWFYgpsKS141AQvOiHAqqQU=; b=LU4h1uVP/33GKOMoXAZoiNWiUiT9g6j2FyQ0kJizxVQzeFB6CxZWGwvm4a9VMJE7HI Rx857AoG8iDcIEUv3Kj3/c2TuEC5cD3irfusyrkuoUJZBcRIydPuHf5TpOL/A8O9gdBr 6EFkmGXYi365Ykr2uC0IcdQr3dKFiGmv1DuWc0xBV2b6kDfBDRGNgpGqKt64Yaldq46v nif4ztatDctVSgoPU8/kNG4o22/w+OHsJ19UjvIOb9pa9aDmrxvo34VC2tI07mS47zGa PQn3uJB6x6/Y7pzmlzkbtKDJyjJda6LXYF56PSGxd+XbCu87yqlQYiB/QZw8bCGu5b0X Ys4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H/QZA3qmfHupeayn4HfaEWFYgpsKS141AQvOiHAqqQU=; b=jdvu8amkw1GXnB+zQW4X0SxvJvMrENqVGyp8ebhzv4zMIe+bQlrVCP7pZtiztSLg1H DRDy3qJAwCKD6LU+iPKA1M/DXAAFONgVQvxboEfVDH7Vuu3x+lv8VqvERWd/diL2xA9x B7zDCkzAoGFMI5wXE7sTM9cZ4+8JlrOo3BG/zsD40gUnQgdbTflq/16CvnwTBFjX/cQ9 bzwUueIQCdnIrS1ud4KeNrCrZIbZE+1mB9cokSEkBaIPFxsArUEMothOvEtDi1Bf6Qqd b2Z9GEqGFW0zqxwooyNaA5+N6utlRb2RR0gj9RUrqudnpq0zy3pBDrdEo6x6Zbj8TWZB gwsQ== X-Gm-Message-State: APjAAAVhnbnJc5T1iFC8bj0VnEk3nLXuMAbZ1bB8dlJkIqrtvSU8lZrb 71e2JfWMt91lJqPhh+TPnSs= X-Google-Smtp-Source: APXvYqwb/Ko4DGk2SEL5W2POn4+qyiZ6Dr2hjZTyj0dWfDzN4INA5PoPUwaLM27C93t0A9YZ46w7eQ== X-Received: by 2002:aa7:9095:: with SMTP id i21mr89836888pfa.134.1555515790264; Wed, 17 Apr 2019 08:43:10 -0700 (PDT) Received: from localhost (c-73-222-71-142.hsd1.ca.comcast.net. [73.222.71.142]) by smtp.gmail.com with ESMTPSA id w189sm108959806pfw.147.2019.04.17.08.43.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 08:43:09 -0700 (PDT) Date: Wed, 17 Apr 2019 08:43:06 -0700 From: Richard Cochran To: Hangbin Liu Cc: netdev@vger.kernel.org, David Miller , Miroslav Lichvar , Patrick McHardy , Jiri Benc , stefan.sorensen@spectralink.com Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device Message-ID: <20190417154306.om6rjkxq4hikhsht@localhost> References: <20190320022333.3378-1-liuhangbin@gmail.com> <20190417061452.GA18865@dhcp-12-139.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190417061452.GA18865@dhcp-12-139.nay.redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 17, 2019 at 04:05:09PM +0800, Hangbin Liu wrote: > On the other hand, Miroslav pointed that with NET_ADMIN enabled in container, > a normal user could be mapped to root and is able to change the real devices's > rx filter via ioctl on macvlan, which may affect the other ptp process on > host. ptp over vlan also has this issue, but macvlan is more frequently used > in container. If NET_ADMIN is enabled in the container, don't the host and container contend with each other for the physical interfaces anyhow? (I'm not a container person, so forgive my ignorance.) Thanks, Richard