From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD6C6C282DA for ; Wed, 17 Apr 2019 19:00:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89155206BA for ; Wed, 17 Apr 2019 19:00:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732910AbfDQTAD (ORCPT ); Wed, 17 Apr 2019 15:00:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8721 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730230AbfDQTAD (ORCPT ); Wed, 17 Apr 2019 15:00:03 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C481E19CBCD; Wed, 17 Apr 2019 19:00:02 +0000 (UTC) Received: from localhost (ovpn-204-196.brq.redhat.com [10.40.204.196]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C83F55C220; Wed, 17 Apr 2019 19:00:00 +0000 (UTC) Date: Wed, 17 Apr 2019 20:59:58 +0200 From: Jiri Benc To: Richard Cochran Cc: Hangbin Liu , netdev@vger.kernel.org, David Miller , Miroslav Lichvar , Patrick McHardy , stefan.sorensen@spectralink.com Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device Message-ID: <20190417205958.6508bda2@redhat.com> In-Reply-To: <20190417154306.om6rjkxq4hikhsht@localhost> References: <20190320022333.3378-1-liuhangbin@gmail.com> <20190417061452.GA18865@dhcp-12-139.nay.redhat.com> <20190417154306.om6rjkxq4hikhsht@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 17 Apr 2019 19:00:03 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 17 Apr 2019 08:43:06 -0700, Richard Cochran wrote: > If NET_ADMIN is enabled in the container, don't the host and container > contend with each other for the physical interfaces anyhow? Physical interfaces are not a problem, as each interface can be only in a single net name space. The problem here is this patch gives access to physical interface settings through a virtual interface layered on top of it. Whenever such thing is done, the virtual interface needs to provide a suitable way of moderating access to the shared resources, so the individual virtual interfaces do not affect each other. That's not what's being done here. I think this patch is wrong. Jiri