From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC01C10F0E for ; Thu, 18 Apr 2019 13:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40BDA217D7 for ; Thu, 18 Apr 2019 13:19:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="zgMmc3Vd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388976AbfDRNTw (ORCPT ); Thu, 18 Apr 2019 09:19:52 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37486 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388253AbfDRNTw (ORCPT ); Thu, 18 Apr 2019 09:19:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qyNQtkzF6xF3IxveXdF5rVw29+g8z+RtTbmXobwtEhM=; b=zgMmc3VdjLYTS+GjmI05Vi1wiM Wgw92Apo+13LwUeuApLQCxot+LGLOUIdz/mU0zZ8TU3YQlh7z2KoUKBMKq7+OkmCAAYb/YcVLlfEA LjPXJAQNG4Rlr8iGlDqJEx3+BT1MTwHZoNilDdOFYdgArd18dSobDWi6WH76DWoYoPrg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hH6x9-0000DY-VK; Thu, 18 Apr 2019 15:19:47 +0200 Date: Thu, 18 Apr 2019 15:19:47 +0200 From: Andrew Lunn To: Sergei Shtylyov Cc: David Miller , netdev , Florian Fainelli , Vivien Didelot Subject: Re: [PATCH net-next 08/15] dsa: Keep link list of tag drivers Message-ID: <20190418131947.GB542@lunn.ch> References: <20190418023120.17067-1-andrew@lunn.ch> <20190418023120.17067-9-andrew@lunn.ch> <19b64e9a-90ce-0645-f3ab-c096b5859258@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19b64e9a-90ce-0645-f3ab-c096b5859258@cogentembedded.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 18, 2019 at 12:35:44PM +0300, Sergei Shtylyov wrote: > On 18.04.2019 5:31, Andrew Lunn wrote: > > >Let the tag drivers register themselves with the DSA core, keeping > >them in a linked list. > > > >Signed-off-by: Andrew Lunn > >--- > > include/net/dsa.h | 2 ++ > > net/dsa/dsa.c | 35 ++++++++++++++++++++++++++++++++++- > > 2 files changed, 36 insertions(+), 1 deletion(-) > > > [...] > >diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c > >index a49e230b6247..861fe1441a7d 100644 > >--- a/net/dsa/dsa.c > >+++ b/net/dsa/dsa.c > >@@ -27,6 +27,9 @@ > [...] > > int dsa_tag_drivers_register(struct dsa_device_ops *ops[], > > unsigned int count, struct module *owner) > > { > >- return 0; > >+ int err, i; > >+ > >+ for (i = 0; i < count; i++) { > >+ err = dsa_tag_driver_register(ops[i], owner); > >+ if (err) > >+ break; > >+ } > >+ > >+ return err; > > What if count == 0? Can't happen? Hi Sergei The current drivers would prevent that. But to be robust, i will add a check. Thanks Andrew