From: Miroslav Lichvar <mlichvar@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
Jiri Benc <jbenc@redhat.com>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
stefan.sorensen@spectralink.com
Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device
Date: Tue, 23 Apr 2019 10:31:41 +0200 [thread overview]
Message-ID: <20190423083141.GA5188@localhost> (raw)
In-Reply-To: <20190423041817.GE18865@dhcp-12-139.nay.redhat.com>
On Tue, Apr 23, 2019 at 12:18:17PM +0800, Hangbin Liu wrote:
> On Thu, Apr 18, 2019 at 10:05:09AM +0200, Miroslav Lichvar wrote:
> > select a more general filter. A container could run a PTP clock if it
>
> Do you have an idea about how to select a general filter? If we have enabled
> HWTSTAMP_FILTER_PTP_V2_L4_SYNC on host and a user in container want to enable
> HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ, then which one is more general?
In this case neither is a more general filter of the other. If
V2_L4_SYNC is already selected, only the following filters could be
selected on the macvlan interface:
HWTSTAMP_FILTER_PTP_V2_L4_SYNC,
HWTSTAMP_FILTER_PTP_V2_L4_EVENT,
HWTSTAMP_FILTER_PTP_V2_SYNC,
HWTSTAMP_FILTER_PTP_V2_EVENT,
HWTSTAMP_FILTER_ALL,
I think one way to check this would be to assign each filter a
(16-bit?) value where the individual bits correspond to the message
types and the newly selected filter would have to contain all bits of
the old one.
> > If I understand it correctly, even without this ioctl a container can
> > prevent the host or other containers from getting some of the HW
> > timestamps by requesting TX timestamps at a high rate. I suspect the
>
> Could traffic sharping/limitation fix it?
Yes, but it has to be specific to packets with TX timestamp requested.
From what I have seen, TX timestamping may start to fail at just few
tens of thousands of packets per second.
--
Miroslav Lichvar
next prev parent reply other threads:[~2019-04-23 8:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 2:23 [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device Hangbin Liu
2019-03-20 18:05 ` David Miller
2019-04-17 8:05 ` Hangbin Liu
2019-04-17 15:43 ` Richard Cochran
2019-04-17 18:59 ` Jiri Benc
2019-04-18 3:31 ` Richard Cochran
2019-04-18 6:10 ` Hangbin Liu
2019-04-18 8:05 ` Miroslav Lichvar
2019-04-23 4:18 ` Hangbin Liu
2019-04-23 8:31 ` Miroslav Lichvar [this message]
2019-04-23 9:15 ` Hangbin Liu
2019-04-23 9:32 ` Miroslav Lichvar
2019-04-25 13:40 ` Hangbin Liu
2019-05-06 7:34 ` Hangbin Liu
2019-05-06 14:01 ` Richard Cochran
2019-05-07 8:35 ` Miroslav Lichvar
2019-05-08 1:41 ` Hangbin Liu
2019-05-08 13:58 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423083141.GA5188@localhost \
--to=mlichvar@redhat.com \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=kaber@trash.net \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).