From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF54C04AA8 for ; Tue, 30 Apr 2019 19:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91DE72087B for ; Tue, 30 Apr 2019 19:40:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="pz1nHFqI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726326AbfD3TkR (ORCPT ); Tue, 30 Apr 2019 15:40:17 -0400 Received: from mail-yw1-f68.google.com ([209.85.161.68]:38687 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726024AbfD3TkR (ORCPT ); Tue, 30 Apr 2019 15:40:17 -0400 Received: by mail-yw1-f68.google.com with SMTP id i66so6812990ywe.5 for ; Tue, 30 Apr 2019 12:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=9hapJfe16PyJZQNfi17Kkf8yv+f1SqUnJbmE8AnYr4E=; b=pz1nHFqIzMz7SkqEfjLv9j53AdOex0KJr1Jjv40jel6TDuOtHLUc1IyvYybLp8+Rg8 SeJCdRW+CcTZYMz97kCsU9qZOMj6GbXBY1FhwQTPRoVkXET6lGsi/we5FwlT4NN8ZgGV D9HvQnd4WUerLRjIl7MHMI+zIzOO1OvFXA9aqxKG1DZKYvc/wdLLXdlne9u8chp4JI7z uSfhgXP+waFbZ+Y+hEAPmfIAv5EQ8iLEFU/LAe+y+912hhXcECsVrLpd9P9lQ2PLIpaa q1rzWkiYHKuoIbD2Cmj8YoOlJZtAIK7eVdnUhNPAJr877KBNLYYtlhevOefACCm8g5v9 QYGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=9hapJfe16PyJZQNfi17Kkf8yv+f1SqUnJbmE8AnYr4E=; b=MjDZGNSkKL18k1nCV7YUOlPNZs/yRxmhFgdQFxo6S4hDZXLFi+zWOd0ygOMfJ28STR GPL4laLC3ypw4MBDY10C0zfRCEE7Q8JyqGtRilfrfYM/Vz58w+XzaGd7KF+tvE3fx1xm /ELcmRbg5zLrI+GY6XYVvpQa0nowWNecCK9/7ErMn5NkuDm+KJrzMgxHIaTXncjPQMeq kDLZ12amBWLhXckFYzEx5h2op7ax5QyoQPNgO58F1tPUGJ+v81NGeuOfu+q6uhBSQrmz +Rzv5kU49pZjOhdkZAw3hzOX60Ac9FX9Jz4KapnPUw/fzb/5olYxEQ09Us/DyHvAYkH/ tghg== X-Gm-Message-State: APjAAAVaKxfpiSH3ZSBygLceFOEL5QtX3Pf38rk8sf+TZL1pwnwdREcO Ah8a+uH1fv4Oq871EVchwrKajg== X-Google-Smtp-Source: APXvYqxqKpnwgH9sBzyVrkWzckuTsdDNH71RQl9Qesa6m+dtdU+SW7zkJIti4k+R188J6xC/gHqb/A== X-Received: by 2002:a25:1d57:: with SMTP id d84mr18191417ybd.40.1556653216257; Tue, 30 Apr 2019 12:40:16 -0700 (PDT) Received: from cakuba (adsl-173-228-226-134.prtc.net. [173.228.226.134]) by smtp.gmail.com with ESMTPSA id p3sm7840711ywf.2.2019.04.30.12.40.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Apr 2019 12:40:16 -0700 (PDT) Date: Tue, 30 Apr 2019 15:39:32 -0400 From: Jakub Kicinski To: Y Song Cc: Quentin Monnet , Alexei Starovoitov , Daniel Borkmann , bpf , netdev , oss-drivers@netronome.com Subject: Re: [PATCH bpf-next 1/6] tools: bpftool: add --log-libbpf option to get debug info from libbpf Message-ID: <20190430153932.7d741d4d@cakuba> In-Reply-To: References: <20190429095227.9745-1-quentin.monnet@netronome.com> <20190429095227.9745-2-quentin.monnet@netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 30 Apr 2019 08:31:53 -0700, Y Song wrote: > On Tue, Apr 30, 2019 at 2:34 AM Quentin Monnet > wrote: > > > > Hi Yonghong, > > > > 2019-04-29 16:32 UTC-0700 ~ Y Song > > > On Mon, Apr 29, 2019 at 2:53 AM Quentin Monnet > > > wrote: > > >> > > >> libbpf has three levels of priority for output: warn, info, debug. By > > >> default, debug output is not printed to stderr. > > >> > > >> Add a new "--log-libbpf LOG_LEVEL" option to bpftool to provide more > > >> flexibility on the log level for libbpf. LOG_LEVEL is a comma-separated > > >> list of levels of log to print ("warn", "info", "debug"). The value > > >> corresponding to the default behaviour would be "warn,info". > > > > > > Do you think option like "warn,debug" will be useful for bpftool users? > > > Maybe at bpftool level, we could allow user only to supply minimum level > > > for log output, e.g., "info" will output "warn,info"? > > I've been pondering this, too. Since we allow to combine all levels for > > the verifier logs it feels a bit odd to be less flexible for libbpf. And > > we could imagine a user who wants verifier logs (so libbpf "debug") but > > prefers to limit libbpf output (so no "info")... Although I admit this > > might be a bit far-fetched. > > > > I can resend a version with the option taking only the minimal log > > level, as you describe, if you think this is best. > > Thanks, I think providing a single minimum level for output probably > better. I have a weak preference for what we have here, because it's similar to the kernel bit opt in (log level, stats etc)..