From: David Miller <davem@davemloft.net>
To: dsahern@kernel.org
Cc: netdev@vger.kernel.org, ian.kumlien@gmail.com,
alan.maguire@oracle.com, dsahern@gmail.com
Subject: Re: [PATCH net] neighbor: Reset gc_entries counter if new entry is released before insert
Date: Sat, 04 May 2019 00:41:00 -0400 (EDT) [thread overview]
Message-ID: <20190504.004100.415091334346243894.davem@davemloft.net> (raw)
In-Reply-To: <20190502010834.25519-1-dsahern@kernel.org>
From: David Ahern <dsahern@kernel.org>
Date: Wed, 1 May 2019 18:08:34 -0700
> From: David Ahern <dsahern@gmail.com>
>
> Ian and Alan both reported seeing overflows after upgrades to 5.x kernels:
> neighbour: arp_cache: neighbor table overflow!
>
> Alan's mpls script helped get to the bottom of this bug. When a new entry
> is created the gc_entries counter is bumped in neigh_alloc to check if a
> new one is allowed to be created. ___neigh_create then searches for an
> existing entry before inserting the just allocated one. If an entry
> already exists, the new one is dropped in favor of the existing one. In
> this case the cleanup path needs to drop the gc_entries counter. There
> is no memory leak, only a counter leak.
>
> Fixes: 58956317c8d ("neighbor: Improve garbage collection")
> Reported-by: Ian Kumlien <ian.kumlien@gmail.com>
> Reported-by: Alan Maguire <alan.maguire@oracle.com>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied and queued up for -stable.
next prev parent reply other threads:[~2019-05-04 4:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 1:08 [PATCH net] neighbor: Reset gc_entries counter if new entry is released before insert David Ahern
2019-05-02 9:53 ` Alan Maguire
2019-05-04 4:41 ` David Miller [this message]
2019-06-06 17:07 ` Jeremy Cline
2019-06-06 17:11 ` David Ahern
2019-06-06 18:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504.004100.415091334346243894.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan.maguire@oracle.com \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=ian.kumlien@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).