From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Edward Cree <ecree@solarflare.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Anjali Singhai Jain <anjali.singhai@intel.com>,
"Or Gerlitz" <gerlitz.or@gmail.com>
Subject: Re: [RFC PATCH net-next 2/3] flow_offload: restore ability to collect separate stats per action
Date: Sat, 4 May 2019 02:27:59 -0400 [thread overview]
Message-ID: <20190504022759.64232fc0@cakuba.netronome.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1905031603340.11823@ehc-opti7040.uk.solarflarecom.com>
On Fri, 3 May 2019 16:06:55 +0100, Edward Cree wrote:
> Introduce a new offload command TC_CLSFLOWER_STATS_BYINDEX, similar to
> the existing TC_CLSFLOWER_STATS but specifying an action_index (the
> tcfa_index of the action), which is called for each stats-having action
> on the rule. Drivers should implement either, but not both, of these
> commands.
>
> Signed-off-by: Edward Cree <ecree@solarflare.com>
> ---
> include/net/pkt_cls.h | 2 ++
> net/sched/cls_flower.c | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 32 insertions(+)
It feels a little strange to me to call the new stats updates from
cls_flower, if we really want to support action sharing correctly.
Can RTM_GETACTION not be used to dump actions without dumping the
classifiers? If we dump from the classifiers wouldn't that lead to
stale stats being returned?
next prev parent reply other threads:[~2019-05-04 6:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 15:06 [RFC PATCH net-next 2/3] flow_offload: restore ability to collect separate stats per action Edward Cree
2019-05-04 6:27 ` Jakub Kicinski [this message]
2019-05-06 12:41 ` Jamal Hadi Salim
2019-05-07 12:27 ` Edward Cree
2019-05-07 17:22 ` Jakub Kicinski
2019-05-08 14:02 ` Jamal Hadi Salim
2019-05-08 17:07 ` Edward Cree
2019-05-09 15:23 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504022759.64232fc0@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=andy@greyhouse.net \
--cc=anjali.singhai@intel.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=gerlitz.or@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).