From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6841DC04A6B for ; Mon, 6 May 2019 18:31:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BEC920B7C for ; Mon, 6 May 2019 18:31:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="EIe86cQ7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726967AbfEFSbe (ORCPT ); Mon, 6 May 2019 14:31:34 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36228 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726927AbfEFSbc (ORCPT ); Mon, 6 May 2019 14:31:32 -0400 Received: by mail-pf1-f196.google.com with SMTP id v80so7216509pfa.3 for ; Mon, 06 May 2019 11:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IfCUWTvSpe/ObcPM/LvXdQ0XKYCGSq77k0PD73RxjWI=; b=EIe86cQ7K8TderF8T7VdJ9IfpOXHbQ4Dzy2wT0wXDDyf6obptddgHxnwhoZi+ehABK yOmUlKW35Oo/Alh8q2aCAPAxQyxZ/AoBBlb1QCOj3Df7DId59pn45lc+9Tf4jXpF0Yd4 PloBwXKn79IsNG6avU6/JP0r8IicZzIyVLyOU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IfCUWTvSpe/ObcPM/LvXdQ0XKYCGSq77k0PD73RxjWI=; b=Fjy6iDX6Ycif6XqfwML+oL49dL7xBjfseC6TPT4UZcu2Bv/Odkgwwr5imx9seyeYBz U++DoPjdXd/ITIL8Pf15e4VQIpQAHR65ClAb35Sr4apG+bddswNXZo3XjgD2dkV9zNo4 /Z0mND4c8zaIJge+jrz2fq0pKhGeQ3OZYROtb56YtOJKECPKjds3XwTMdQV1hFIvsEW8 44AdU/FxxhrKWi4mG16WLAYOPr7vI/z4t4ho8/dyQhYS47ELnHdstiuAv3NI3Y+atssf TlgfQSqi/y3d03vR/Q0PGPJVgg0V/DvMjrNBOPnvoO56CQUijrnulmL5hj6dzJOH3fvv dV1w== X-Gm-Message-State: APjAAAVHS+Yy89BIJlJ2RlkB/h7YNkt/hw2w8X8DpzQEI6V1e7/fy/JU 4rhoBU/Q96yDERXvzzNdlGpv4Q== X-Google-Smtp-Source: APXvYqw87aBaFaX0JfldiFHxy8FnYx3ibxSNeKODs8Fn08SOhD4IlfvMrdf+aewDAAvL101n3sCA7A== X-Received: by 2002:a63:a18:: with SMTP id 24mr33507004pgk.332.1557167491372; Mon, 06 May 2019 11:31:31 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id h30sm21412414pgi.38.2019.05.06.11.31.28 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 06 May 2019 11:31:30 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Adrian Ratiu , Alexei Starovoitov , Andrii Nakryiko , bpf@vger.kernel.org, Brendan Gregg , Daniel Borkmann , duyuchao , Ingo Molnar , Karim Yaghmour , Kees Cook , kernel-team@android.com, Manjo Raja Rao , Martin KaFai Lau , Masami Hiramatsu , Michal Gregorczyk , Mohammad Husain , netdev@vger.kernel.org, Peter Ziljstra , Qais Yousef , Song Liu , Srinivas Ramana , Steven Rostedt , Tamir Carmeli , Yonghong Song Subject: [PATCH v2 3/4] bpf: Add warning when program uses deprecated bpf_probe_read Date: Mon, 6 May 2019 14:31:15 -0400 Message-Id: <20190506183116.33014-3-joel@joelfernandes.org> X-Mailer: git-send-email 2.21.0.1020.gf2820cf01a-goog In-Reply-To: <20190506183116.33014-1-joel@joelfernandes.org> References: <20190506183116.33014-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org bpf_probe_read is deprecated and ambiguous. Add a warning if programs still use it, so that they may be moved to not use it. After sufficient time, the warning can be removed. Signed-off-by: Joel Fernandes (Google) --- kernel/bpf/verifier.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 09d5d972c9ff..f8cc77e85b48 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -7656,6 +7656,10 @@ static int fixup_bpf_calls(struct bpf_verifier_env *env) if (insn->src_reg == BPF_PSEUDO_CALL) continue; + if (insn->imm == BPF_FUNC_probe_read) + pr_warn_once("bpf_probe_read is deprecated, please use " + "bpf_probe_read_{kernel,user} in eBPF programs.\n"); + if (insn->imm == BPF_FUNC_get_route_realm) prog->dst_needed = 1; if (insn->imm == BPF_FUNC_get_prandom_u32) -- 2.21.0.1020.gf2820cf01a-goog