From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57608C004C9 for ; Tue, 7 May 2019 06:03:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B12E20675 for ; Tue, 7 May 2019 06:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557209028; bh=GGMllsJGL70Wd30hAUJvDQAa7WiQC42hvwxpkkNUawc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ApWHd0miS/K6G6/9IInuZ9pvgMQA0639uCez88PMKPIZteGykZO6XkSgKfUQAA/Ps tQIPndtNKVnc2WuyCCnWIvGK18w1pbZzbv643VW037kxhJ1KhiAt9zAxfTdiomuvrd YuL/9ab4ePlQar07zY2s3N8D68tQmXcZvUeqtsAs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727692AbfEGFfD (ORCPT ); Tue, 7 May 2019 01:35:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:55074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727664AbfEGFfC (ORCPT ); Tue, 7 May 2019 01:35:02 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E176E20C01; Tue, 7 May 2019 05:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557207301; bh=GGMllsJGL70Wd30hAUJvDQAa7WiQC42hvwxpkkNUawc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DbRdaVuC8ODFJRPxTBqBOn8DsfJygTPaT+5b7owFI3HdLndWDeAWm27Sute6/L59M EcDwIZERiv1k2zCikSMESXff4IrWwzn2VDf2qiN5PNhgi/0YSgZ91wd/QNbK/M9kBH 3LcgW4lBR0wnpkoNnL/GNdJJUHzeep5Ths9gV/uw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Po-Hsu Lin , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 5.0 72/99] selftests/net: correct the return value for run_netsocktests Date: Tue, 7 May 2019 01:32:06 -0400 Message-Id: <20190507053235.29900-72-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190507053235.29900-1-sashal@kernel.org> References: <20190507053235.29900-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Po-Hsu Lin [ Upstream commit 30c04d796b693e22405c38e9b78e9a364e4c77e6 ] The run_netsocktests will be marked as passed regardless the actual test result from the ./socket: selftests: net: run_netsocktests ======================================== -------------------- running socket test -------------------- [FAIL] ok 1..6 selftests: net: run_netsocktests [PASS] This is because the test script itself has been successfully executed. Fix this by exit 1 when the test failed. Signed-off-by: Po-Hsu Lin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- tools/testing/selftests/net/run_netsocktests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/run_netsocktests b/tools/testing/selftests/net/run_netsocktests index b093f39c298c..14e41faf2c57 100755 --- a/tools/testing/selftests/net/run_netsocktests +++ b/tools/testing/selftests/net/run_netsocktests @@ -7,7 +7,7 @@ echo "--------------------" ./socket if [ $? -ne 0 ]; then echo "[FAIL]" + exit 1 else echo "[PASS]" fi - -- 2.20.1