From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Michael, Alice" <alice.michael@intel.com>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"Marczak, Piotr" <piotr.marczak@intel.com>,
"Buchholz, Donald" <donald.buchholz@intel.com>
Subject: Re: [net-next v2 11/11] i40e: Introduce recovery mode support
Date: Tue, 7 May 2019 14:22:14 -0700 [thread overview]
Message-ID: <20190507142214.26611a49@cakuba.hsd1.ca.comcast.net> (raw)
In-Reply-To: <CD14C679C9B9B1409B02829D9B523C290AE87E5E@ORSMSX112.amr.corp.intel.com>
On Tue, 7 May 2019 18:51:02 +0000, Michael, Alice wrote:
> > -----Original Message-----
> > From: Jakub Kicinski [mailto:jakub.kicinski@netronome.com]
> > Sent: Saturday, May 4, 2019 4:35 AM
> > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Michael, Alice
> > <alice.michael@intel.com>
> > Cc: davem@davemloft.net; netdev@vger.kernel.org; nhorman@redhat.com;
> > sassmann@redhat.com; Marczak, Piotr <piotr.marczak@intel.com>; Buchholz,
> > Donald <donald.buchholz@intel.com>
> > Subject: Re: [net-next v2 11/11] i40e: Introduce recovery mode support
> >
> > On Fri, 3 May 2019 16:09:39 -0700, Jeff Kirsher wrote:
> > > From: Alice Michael <alice.michael@intel.com>
> > >
> > > This patch introduces "recovery mode" to the i40e driver. It is part
> > > of a new Any2Any idea of upgrading the firmware. In this approach, it
> > > is required for the driver to have support for "transition firmware",
> > > that is used for migrating from structured to flat firmware image. In
> > > this new, very basic mode, i40e driver must be able to handle
> > > particular IOCTL calls from the NVM Update Tool and run a small set of
> > > AQ commands.
> >
> > What's the "particular IOCTL" you speak of? This patch adds a fake netdev with
> > a .set_eeprom callback. Are you wrapping the AQ commands in the set_eeprom
> > now? Or is there some other IOCTL here?
>
> Yes. The NVMUpdate tool uses the ethtool IOCTL to call the
> driver's .set_eeprom callback. This then triggers the firmware AQ
> command. The fake netdev needs to have ethtool support to finish
> upgrading the firmware using the eeprom interface.
To be clear - the .set_eeprom calls are used to carry some marshalled
commands, not just the raw data to be written into flash? Right?
Otherwise your tool wouldn't be necessary.
> > Let me repeat my other question - can the netdev you spawn in
> > i40e_init_recovery_mode() pass traffic?
>
> No, the device is not expected to pass traffic. This mode is to
> allow the NVMUpdate to program the NVM.
Creating this fake netdev which can't pass traffic is quite bad, and
pointless given that devlink is capable of handling firmware updates.
next prev parent reply other threads:[~2019-05-07 21:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 23:09 [net-next v2 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2019-05-03 Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 01/11] i40e: Fix for allowing too many MDD events on VF Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 02/11] i40e: change behavior on PF in response to MDD event Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 03/11] i40e: remove error msg when vf with port vlan tries to remove vlan 0 Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 04/11] i40e: ShadowRAM checksum calculation change Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 05/11] i40e: Report advertised link modes on 40GBase_LR4, CR4 and fibre Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 06/11] i40e: Further implementation of LLDP Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 07/11] i40e: remove out-of-range comparisons in i40e_validate_cloud_filter Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 08/11] i40e: update version number Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 09/11] i40e: fix misleading message about promisc setting on un-trusted VF Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 10/11] i40e: print PCI vendor and device ID during probe Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 11/11] i40e: Introduce recovery mode support Jeff Kirsher
2019-05-04 11:35 ` Jakub Kicinski
2019-05-05 1:23 ` Jeff Kirsher
2019-05-07 18:51 ` Michael, Alice
2019-05-07 21:22 ` Jakub Kicinski [this message]
2019-05-04 3:32 ` [net-next v2 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2019-05-03 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507142214.26611a49@cakuba.hsd1.ca.comcast.net \
--to=jakub.kicinski@netronome.com \
--cc=alice.michael@intel.com \
--cc=davem@davemloft.net \
--cc=donald.buchholz@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=piotr.marczak@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).