From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com,
miquel.raynal@bootlin.com, nadavh@marvell.com,
stefanc@marvell.com, mw@semihalf.com,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net] net: mvpp2: cls: Add missing NETIF_F_NTUPLE flag
Date: Thu, 9 May 2019 10:44:03 -0700 [thread overview]
Message-ID: <20190509104403.64c9c45b@cakuba.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20190509071408.23eae42a@bootlin.com>
On Thu, 9 May 2019 07:14:08 +0200, Maxime Chevallier wrote:
> Hello Jakub, David,
>
> On Tue, 7 May 2019 10:28:03 -0700
> Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
>
> >> - if (mvpp22_rss_is_supported())
> >> + if (mvpp22_rss_is_supported()) {
> >> dev->hw_features |= NETIF_F_RXHASH;
> >> + dev->features |= NETIF_F_NTUPLE;
> >
> >Hm, why not in hw_features?
>
> Because as of today, there's nothing implemented to disable
> classification offload in the driver, so the feature can't be toggled.
>
> Is this an issue ? Sorry if I'm doing this wrong, but I didn't see any
> indication that this feature has to be host-writeable.
No I don't think it's an issue, I was expecting you'd flush all the
filters when feature is disabled (remove them entirely), I didn't
expect that to be too hard.
> I can make so that it's toggle-able, but it's not as straightforward as
> we would think, since the classifier is also used for RSS (so, we can't
> just disable the classifier as a whole, we would have to invalidate
> each registered flow).
Ack, I don't think disabling the hardware components is required.
Just remove the existing filters, and don't allow new ones.
But no strong feelings here, feel free to repost with:
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
if flushing the filters is too much hassle.
next prev parent reply other threads:[~2019-05-09 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 12:36 [PATCH net] net: mvpp2: cls: Add missing NETIF_F_NTUPLE flag Maxime Chevallier
2019-05-07 17:28 ` Jakub Kicinski
2019-05-09 5:14 ` Maxime Chevallier
2019-05-09 17:44 ` Jakub Kicinski [this message]
2019-05-07 19:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509104403.64c9c45b@cakuba.hsd1.ca.comcast.net \
--to=jakub.kicinski@netronome.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).