From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9E29C04AB4 for ; Fri, 17 May 2019 22:55:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA4C82082E for ; Fri, 17 May 2019 22:55:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IF+6pl0A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727181AbfEQWyo (ORCPT ); Fri, 17 May 2019 18:54:44 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:46905 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729303AbfEQWyo (ORCPT ); Fri, 17 May 2019 18:54:44 -0400 Received: by mail-pl1-f195.google.com with SMTP id r18so3970005pls.13 for ; Fri, 17 May 2019 15:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ul1gLClLY2RLZ2itEzzFB2yOFIqulLy55JPQTAySFDo=; b=IF+6pl0A6m1fIH81uzmdTDMrurVWOxHBgZdzg9ueW18kyGxlj6N5aPcTRqNNCU+vTS LKiCjnkbIC7ajqH/YtTymknHPW/NY4yPjYIJzDwwYqMMyIAHIYA46a6IB8NY149qfCHK CVTekqT/FiWMIwMhhNjynCJ139h41IPM+Swp8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ul1gLClLY2RLZ2itEzzFB2yOFIqulLy55JPQTAySFDo=; b=GTbI5w038UyK6qYKV9dAf78xl+lHuNKo3cpymftqx0/TmJ41U8aX919r1rSZ4SUXg9 1h8bLByl7bDtwB0ZN04lT0bYRoiU8alYLNoSeKi4RsmfDCtyOidsmG/VGZ5BSuM8K1vN f7l5o+xln/3auw16yAwcaQfJ0dtN5uAMHfOdmmBxA14VyJ3T7/TDrcGDWZ+VJIcJsqMJ z98g/DmOF/cFdYnfuBV38U/IuLWAs77BxfIxeP3ezGmWQHXYMLsikn5CyHPcklYOz7RC 4ISo5vuah9Fri1NNgn+iPPUfGxu4fxYtI2qDlBZzER/UJBGCO7I0qfVeY1CfmJWy4rco vx2A== X-Gm-Message-State: APjAAAXRDYSur+bFPrq//9BDlXR9ZrwJRrgwYKnNENKs3CpDwU58zHWg 8ypB2Z8yhP5rmwFDmKfhON8WbA== X-Google-Smtp-Source: APXvYqz/J4eNQzJXQjOFtQWVtg1bZz7U+KE/9+kUa8iLb3eFelZBp/fzq1UlgJul23Nw2JUqc2sKmA== X-Received: by 2002:a17:902:7797:: with SMTP id o23mr58590219pll.147.1558133683494; Fri, 17 May 2019 15:54:43 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id u11sm11174450pfh.130.2019.05.17.15.54.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 15:54:42 -0700 (PDT) From: Douglas Anderson To: Ulf Hansson , Kalle Valo , Adrian Hunter , Arend van Spriel Cc: linux-rockchip@lists.infradead.org, Double Lo , briannorris@chromium.org, Madhan Mohan R , mka@chromium.org, Wright Feng , Chi-Hsien Lin , Douglas Anderson , linux-mmc@vger.kernel.org, Shawn Lin , brcm80211-dev-list@cypress.com, YueHaibing , Hante Meuleman , Martin Hicks , Ritesh Harjani , Michael Trimarchi , Wolfram Sang , Franky Lin , Jiong Wu , brcm80211-dev-list.pdl@broadcom.com, "David S. Miller" , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Naveen Gupta , Madhan Mohan R , Avri Altman Subject: [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep Date: Fri, 17 May 2019 15:54:17 -0700 Message-Id: <20190517225420.176893-1-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.1020.gf2820cf01a-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This series attempts to deal better with the expected transmission errors that we get when waking up the SDIO-based WiFi on rk3288-veyron-minnie, rk3288-veyron-speedy, and rk3288-veyron-mickey. Some details about those errors can be found in , but to summarize it here: if we try to send the wakeup command to the WiFi card at the same time it has decided to wake up itself then it will behave badly on the SDIO bus. This can cause timeouts or CRC errors. When I tested on 4.19 and 4.20 these CRC errors can be seen to cause re-tuning. Since I am currently developing on 4.19 this was the original problem I attempted to solve. On mainline it turns out that you don't see the retuning errors but you see tons of spam about timeouts trying to wakeup from sleep. I tracked down the commit that was causing that and have partially reverted it here. I have no real knowledge about Broadcom WiFi, but the commit that was causing problems sounds (from the descriptioin) to be a hack commit penalizing all Broadcom WiFi users because of a bug in a Cypress SD controller. I will let others comment if this is truly the case and, if so, what the right solution should be. Douglas Anderson (3): brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 mmc: core: API for temporarily disabling auto-retuning due to errors brcmfmac: sdio: Disable auto-tuning around commands expected to fail drivers/mmc/core/core.c | 27 +++++++++++++++++-- .../broadcom/brcm80211/brcmfmac/sdio.c | 6 +++-- include/linux/mmc/core.h | 2 ++ include/linux/mmc/host.h | 1 + 4 files changed, 32 insertions(+), 4 deletions(-) -- 2.21.0.1020.gf2820cf01a-goog