* linux-next: build warning after merge of the net-next tree
@ 2019-05-23 23:47 Stephen Rothwell
2019-05-24 5:24 ` [PATCH] net: ll_temac: Fix compile error Esben Haabendal
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2019-05-23 23:47 UTC (permalink / raw)
To: David Miller, Networking
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Esben Haabendal
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hi all,
After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_set_multicast_list':
drivers/net/ethernet/xilinx/ll_temac_main.c:490:8: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
while (i < MULTICAST_CAM_TABLE_NUM) {
^
Introduced by commit
1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] net: ll_temac: Fix compile error
2019-05-23 23:47 linux-next: build warning after merge of the net-next tree Stephen Rothwell
@ 2019-05-24 5:24 ` Esben Haabendal
2019-05-24 5:30 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Esben Haabendal @ 2019-05-24 5:24 UTC (permalink / raw)
To: Stephen Rothwell
Cc: David S. Miller, Michal Simek, Andrew Lunn, YueHaibing,
Petr Štetiar, netdev, linux-arm-kernel, linux-kernel
Fixes: 1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change")
Signed-off-by: Esben Haabendal <esben@geanix.com>
---
drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 22a52b884821..21c1b4322ea7 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -452,7 +452,7 @@ static void temac_set_multicast_list(struct net_device *ndev)
{
struct temac_local *lp = netdev_priv(ndev);
u32 multi_addr_msw, multi_addr_lsw;
- int i;
+ int i = 0;
unsigned long flags;
bool promisc_mode_disabled = false;
@@ -468,7 +468,6 @@ static void temac_set_multicast_list(struct net_device *ndev)
if (!netdev_mc_empty(ndev)) {
struct netdev_hw_addr *ha;
- i = 0;
netdev_for_each_mc_addr(ha, ndev) {
if (WARN_ON(i >= MULTICAST_CAM_TABLE_NUM))
break;
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ll_temac: Fix compile error
2019-05-24 5:24 ` [PATCH] net: ll_temac: Fix compile error Esben Haabendal
@ 2019-05-24 5:30 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2019-05-24 5:30 UTC (permalink / raw)
To: esben
Cc: sfr, michal.simek, andrew, yuehaibing, ynezz, netdev,
linux-arm-kernel, linux-kernel
From: Esben Haabendal <esben@geanix.com>
Date: Fri, 24 May 2019 07:24:42 +0200
> Fixes: 1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change")
> Signed-off-by: Esben Haabendal <esben@geanix.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-24 5:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 23:47 linux-next: build warning after merge of the net-next tree Stephen Rothwell
2019-05-24 5:24 ` [PATCH] net: ll_temac: Fix compile error Esben Haabendal
2019-05-24 5:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).