From: Jiri Pirko <jiri@resnulli.us>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] team: add ethtool get_link_ksettings
Date: Tue, 28 May 2019 13:24:31 +0200 [thread overview]
Message-ID: <20190528112431.GA2252@nanopsycho> (raw)
In-Reply-To: <20190528100211.GX18865@dhcp-12-139.nay.redhat.com>
Tue, May 28, 2019 at 12:02:11PM CEST, liuhangbin@gmail.com wrote:
>On Tue, May 28, 2019 at 11:08:23AM +0200, Jiri Pirko wrote:
>> >+static int team_ethtool_get_link_ksettings(struct net_device *dev,
>> >+ struct ethtool_link_ksettings *cmd)
>> >+{
>> >+ struct team *team= netdev_priv(dev);
>> >+ unsigned long speed = 0;
>> >+ struct team_port *port;
>> >+
>> >+ cmd->base.duplex = DUPLEX_UNKNOWN;
>> >+ cmd->base.port = PORT_OTHER;
>> >+
>> >+ list_for_each_entry(port, &team->port_list, list) {
>> >+ if (team_port_txable(port)) {
>> >+ if (port->state.speed != SPEED_UNKNOWN)
>> >+ speed += port->state.speed;
>> >+ if (cmd->base.duplex == DUPLEX_UNKNOWN &&
>> >+ port->state.duplex != DUPLEX_UNKNOWN)
>> >+ cmd->base.duplex = port->state.duplex;
>>
>> What is exactly the point of this patch? Why do you need such
>> information. This is hw-related info. If you simply sum-up all txable
>> ports, the value is always highly misleading.
>>
>> For example for hash-based port selection with 2 100Mbit ports,
>> you will get 200Mbit, but it is not true. It is up to the traffic and
>> hash function what is the actual TX speed you can get.
>> On the RX side, this is even more misleading as the actual speed depends
>> on the other side of the wire.
>
>The number is the maximum speed in theory. I added it because someone
"in theory" is not what this value should return in my opinion.
>said bond interface could show total speed while team could not...
>The usage is customer could get team link-speed and throughput via SNMP.
Has no meaning though :/
>
>Thanks
>Hangbin
>>
>>
>> >+ }
>> >+ }
>> >+ cmd->base.speed = speed ? : SPEED_UNKNOWN;
>> >+
>> >+ return 0;
>> >+}
>> >+
>> > static const struct ethtool_ops team_ethtool_ops = {
>> > .get_drvinfo = team_ethtool_get_drvinfo,
>> > .get_link = ethtool_op_get_link,
>> >+ .get_link_ksettings = team_ethtool_get_link_ksettings,
>> > };
>> >
>> > /***********************
>> >--
>> >2.19.2
>> >
next prev parent reply other threads:[~2019-05-28 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 3:31 [PATCH net-next] team: add ethtool get_link_ksettings Hangbin Liu
2019-05-27 17:09 ` David Miller
2019-05-28 9:08 ` Jiri Pirko
2019-05-28 10:02 ` Hangbin Liu
2019-05-28 11:24 ` Jiri Pirko [this message]
2019-06-13 6:16 ` Hangbin Liu
2019-06-14 8:32 ` Jiri Pirko
2019-06-14 15:55 ` David Miller
2019-06-14 8:32 ` Jiri Pirko
2019-06-17 1:32 ` [PATCHv2 " Hangbin Liu
2019-06-17 9:03 ` Jiri Pirko
2019-06-17 20:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528112431.GA2252@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).