From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=3.0 tests=DATE_IN_PAST_06_12, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DFFC28CC1 for ; Sat, 1 Jun 2019 16:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A0F22768F for ; Sat, 1 Jun 2019 16:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559406011; bh=kunCWeTycOmy9TLLHVnQa/oWK5UyHy4K/bFS9zHk1Qw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1GlmJF6Vdj+3VL7ZeNyqmWY9rLhFW6oWDNNmvNyPch0DiZg2MXTrRPbKHrThiqa8+ Qq2M+e7l9QQTLeG+IlW+2hts0wfC/9BG0yqrdR8EnCAJY08LCUNwiicfZxHeuqFmN7 UEUWAKXChwlCZryRrSL3cU6ov3+Vc2YSZ19X4XrU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbfFAQUK (ORCPT ); Sat, 1 Jun 2019 12:20:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:58874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726143AbfFAQUJ (ORCPT ); Sat, 1 Jun 2019 12:20:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C05842768D; Sat, 1 Jun 2019 16:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559406009; bh=kunCWeTycOmy9TLLHVnQa/oWK5UyHy4K/bFS9zHk1Qw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l+cjig3LN5W1sHK1uM8ZUZgjejYsqVrhCI47kldCOZZi8iTRMAKj0qvMAiLDDfs1Z V4YnNmUoxij7X1AFo5ewCqGtePYxWHXdpoozR8fMFN0Rh5efOUqVhlzEXJud+kOrIR jExiLyHfh1MngKgEKISRBjws3IxX0sZ5r6BkYk1c= Date: Sat, 1 Jun 2019 02:32:44 -0700 From: Greg KH To: Maciej =?utf-8?Q?=C5=BBenczykowski?= Cc: David Miller , Lorenzo Colitti , astrachan@google.com, liuhangbin@gmail.com, Linux NetDev , mateusz.bajorski@nokia.com, dsa@cumulusnetworks.com Subject: Re: [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied Message-ID: <20190601093244.GB1783@kroah.com> References: <20190507091118.24324-1-liuhangbin@gmail.com> <20190508.093541.1274244477886053907.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 31, 2019 at 06:43:42PM -0700, Maciej Żenczykowski wrote: > FYI, this userspace visible change in behaviour breaks Android. > > We rely on being able to add a rule and either have a dup be created > (in which case we'll remove it later) or have it fail with EEXIST (in > which case we won't remove it later). > > Returning 0 makes atomically changing a rule difficult. > > Please revert. That's crazy, but makes sense in an odd way :) And it explains why my "fix up of the patch" also breaks things, both patches need to be reverted in the stable trees. Do you need me to make a patch to revert this in Linus's tree now, or can you do that? Just asking for an existing commit to be reverted is usually a bit harder as that's not most maintainer's workflow (I know it's not mine.) thanks, gre gk-h