netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 net-next] net: fec_ptp: Use dev_err() instead of pr_err()
@ 2019-06-05 13:10 Fabio Estevam
  2019-06-05 19:13 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2019-06-05 13:10 UTC (permalink / raw)
  To: davem; +Cc: fugang.duan, netdev, Fabio Estevam

dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
---
Changes since v2:
- Made it a standalone patch
- Collected Andy's Ack

 drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index 7e892b1cbd3d..19e2365be7d8 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -617,7 +617,7 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx)
 	fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev);
 	if (IS_ERR(fep->ptp_clock)) {
 		fep->ptp_clock = NULL;
-		pr_err("ptp_clock_register failed\n");
+		dev_err(&pdev->dev, "ptp_clock_register failed\n");
 	}
 
 	schedule_delayed_work(&fep->time_keep, HZ);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 net-next] net: fec_ptp: Use dev_err() instead of pr_err()
  2019-06-05 13:10 [PATCH v3 net-next] net: fec_ptp: Use dev_err() instead of pr_err() Fabio Estevam
@ 2019-06-05 19:13 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-05 19:13 UTC (permalink / raw)
  To: festevam; +Cc: fugang.duan, netdev

From: Fabio Estevam <festevam@gmail.com>
Date: Wed,  5 Jun 2019 10:10:35 -0300

> dev_err() is more appropriate for printing error messages inside
> drivers, so switch to dev_err().
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> Changes since v2:
> - Made it a standalone patch
> - Collected Andy's Ack

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-05 19:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 13:10 [PATCH v3 net-next] net: fec_ptp: Use dev_err() instead of pr_err() Fabio Estevam
2019-06-05 19:13 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).