From: David Miller <davem@davemloft.net>
To: natechancellor@gmail.com
Cc: liuhangbin@gmail.com, netdev@vger.kernel.org,
gregkh@linuxfoundation.org, zenczykowski@gmail.com,
lorenzo@google.com, dsa@cumulusnetworks.com, thaller@redhat.com,
yaro330@gmail.com
Subject: Re: [PATCH net] Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied"
Date: Wed, 05 Jun 2019 18:41:12 -0700 (PDT) [thread overview]
Message-ID: <20190605.184112.199298828409456934.davem@davemloft.net> (raw)
In-Reply-To: <20190606012351.GA29571@archlinux-epyc>
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Wed, 5 Jun 2019 18:23:51 -0700
> On Wed, Jun 05, 2019 at 05:55:26PM -0700, David Miller wrote:
>> From: Hangbin Liu <liuhangbin@gmail.com>
>> Date: Wed, 5 Jun 2019 12:27:14 +0800
>>
>> > This reverts commit e9919a24d3022f72bcadc407e73a6ef17093a849.
>> >
>> > Nathan reported the new behaviour breaks Android, as Android just add
>> > new rules and delete old ones.
>> >
>> > If we return 0 without adding dup rules, Android will remove the new
>> > added rules and causing system to soft-reboot.
>> >
>> > Reported-by: Nathan Chancellor <natechancellor@gmail.com>
>> > Fixes: e9919a24d302 ("fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied")
>> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>>
>> Applied.
>
> Please ensure this gets queued up for stable, as that is where I noticed
> the issue.
It is queued up, thanks for asking.
I'll try to get this propagated as soon as possible.
Thanks again.
prev parent reply other threads:[~2019-06-06 1:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 4:27 [PATCH net] Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied" Hangbin Liu
2019-06-05 5:44 ` Nathan Chancellor
2019-06-06 0:55 ` David Miller
2019-06-06 1:23 ` Nathan Chancellor
2019-06-06 1:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605.184112.199298828409456934.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=gregkh@linuxfoundation.org \
--cc=liuhangbin@gmail.com \
--cc=lorenzo@google.com \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=thaller@redhat.com \
--cc=yaro330@gmail.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).