From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 576E5C28CC5 for ; Thu, 6 Jun 2019 01:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 367AD2070B for ; Thu, 6 Jun 2019 01:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbfFFBtD (ORCPT ); Wed, 5 Jun 2019 21:49:03 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44098 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726613AbfFFBtD (ORCPT ); Wed, 5 Jun 2019 21:49:03 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 88305144DC6C5; Wed, 5 Jun 2019 18:49:02 -0700 (PDT) Date: Wed, 05 Jun 2019 18:49:02 -0700 (PDT) Message-Id: <20190605.184902.257610327160365131.davem@davemloft.net> To: liuzhiqiang26@huawei.com Cc: edumazet@google.com, netdev@vger.kernel.org, mingfangsen@huawei.com, zhoukang7@huawei.com, wangxiaogang3@huawei.com Subject: Re: [PATCH net] inet_connection_sock: remove unused parameter of reqsk_queue_unlink func From: David Miller In-Reply-To: <546c6d2f-39ca-521d-7009-d80df735bd9e@huawei.com> References: <40f32663-f100-169c-4d1b-79d64d68a5f9@huawei.com> <546c6d2f-39ca-521d-7009-d80df735bd9e@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 05 Jun 2019 18:49:02 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Zhiqiang Liu Date: Wed, 5 Jun 2019 18:49:49 +0800 > small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink > func is never used in the func, so we can remove it. > > Signed-off-by: Zhiqiang Liu Applied, thanks.