From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Andrew Bowers <andrewx.bowers@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 05/15] ixgbe: reduce PTP Tx timestamp timeout to 1 second
Date: Wed, 5 Jun 2019 13:23:48 -0700 [thread overview]
Message-ID: <20190605202358.2767-6-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20190605202358.2767-1-jeffrey.t.kirsher@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
Previously we waited for a whole 15 seconds before we cleared the Tx
timestamp state. This is astronomically long compared to the worst case
timings expected by our devices. In addition, this is longer than the
wait in ptp4l when it detects a fault (caused by missing Tx timestamps).
Thus, reduce the timer to only 1 second, which is well after the maximum
expected delay. This should reduce user frustration when a timestamp
does get dropped for some reason.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
index d81a50dc9535..dbe84a4d2f7f 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
@@ -72,7 +72,7 @@
#define IXGBE_INCPER_SHIFT_82599 24
#define IXGBE_OVERFLOW_PERIOD (HZ * 30)
-#define IXGBE_PTP_TX_TIMEOUT (HZ * 15)
+#define IXGBE_PTP_TX_TIMEOUT (HZ)
/* half of a one second clock period, for use with PPS signal. We have to use
* this instead of something pre-defined like IXGBE_PTP_PPS_HALF_SECOND, in
--
2.21.0
next prev parent reply other threads:[~2019-06-05 20:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 20:23 [net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2019-06-05 Jeff Kirsher
2019-06-05 20:23 ` [net-next 01/15] ixgbe: add tracking of AF_XDP zero-copy state for each queue pair Jeff Kirsher
2019-06-05 20:23 ` [net-next 02/15] ixgbe: remove umem from adapter Jeff Kirsher
2019-06-05 20:23 ` [net-next 03/15] ixgbe: fix AF_XDP tx byte count Jeff Kirsher
2019-06-05 20:23 ` [net-next 04/15] ixgbe: fix AF_XDP tx packet count Jeff Kirsher
2019-06-05 20:23 ` Jeff Kirsher [this message]
2019-06-05 20:23 ` [net-next 06/15] ixgbe: fix PTP SDP pin setup on X540 hardware Jeff Kirsher
2019-06-06 3:20 ` Richard Cochran
2019-06-06 20:37 ` Keller, Jacob E
2019-06-07 3:34 ` Richard Cochran
2019-06-07 17:27 ` Keller, Jacob E
2019-06-05 20:23 ` [net-next 07/15] ixgbe: use 'cc' instead of 'hw_cc' for local variable Jeff Kirsher
2019-06-05 20:23 ` [net-next 08/15] ixgbe: add a kernel documentation comment for ixgbe_ptp_get_ts_config Jeff Kirsher
2019-06-05 20:23 ` [net-next 09/15] net: Add a define for LLDP ethertype Jeff Kirsher
2019-06-05 20:23 ` [net-next 10/15] i40e: Use LLDP ethertype define ETH_P_LLDP Jeff Kirsher
2019-06-05 20:23 ` [net-next 11/15] ixgbe: " Jeff Kirsher
2019-06-05 20:23 ` [net-next 12/15] ice: " Jeff Kirsher
2019-06-05 20:23 ` [net-next 13/15] net: hns3: " Jeff Kirsher
2019-06-05 20:23 ` [net-next 14/15] ixgbe: implement support for SDP/PPS output on X550 hardware Jeff Kirsher
2019-06-05 20:23 ` [net-next 15/15] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack Jeff Kirsher
2019-06-05 23:44 ` [net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2019-06-05 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605202358.2767-6-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=andrewx.bowers@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).