From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B36C04AB5 for ; Thu, 6 Jun 2019 17:39:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBCEF20872 for ; Thu, 6 Jun 2019 17:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730237AbfFFRj0 (ORCPT ); Thu, 6 Jun 2019 13:39:26 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54682 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728646AbfFFRjZ (ORCPT ); Thu, 6 Jun 2019 13:39:25 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D6B7014DD4FB6; Thu, 6 Jun 2019 10:39:24 -0700 (PDT) Date: Thu, 06 Jun 2019 10:39:24 -0700 (PDT) Message-Id: <20190606.103924.1369913278652387015.davem@davemloft.net> To: maxime.chevallier@bootlin.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com Subject: Re: [PATCH net] net: mvpp2: Use strscpy to handle stat strings From: David Miller In-Reply-To: <20190606084256.3703-1-maxime.chevallier@bootlin.com> References: <20190606084256.3703-1-maxime.chevallier@bootlin.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Jun 2019 10:39:25 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maxime Chevallier Date: Thu, 6 Jun 2019 10:42:56 +0200 > Use a safe strscpy call to copy the ethtool stat strings into the > relevant buffers, instead of a memcpy that will be accessing > out-of-bound data. > > Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics") > Signed-off-by: Maxime Chevallier Applied and queued up for -stable.