From: Martin Lau <kafai@fb.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: "alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"oss-drivers@netronome.com" <oss-drivers@netronome.com>,
Quentin Monnet <quentin.monnet@netronome.com>
Subject: Re: [PATCH bpf-next v2] samples: bpf: print a warning about headers_install
Date: Thu, 6 Jun 2019 00:03:29 +0000 [thread overview]
Message-ID: <20190606000326.mrgtzfud55a4kczj@kafai-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20190605234722.2291-1-jakub.kicinski@netronome.com>
On Wed, Jun 05, 2019 at 04:47:22PM -0700, Jakub Kicinski wrote:
> It seems like periodically someone posts patches to "fix"
> header includes. The issue is that samples expect the
> include path to have the uAPI headers (from usr/) first,
> and then tools/ headers, so that locally installed uAPI
> headers take precedence. This means that if users didn't
> run headers_install they will see all sort of strange
> compilation errors, e.g.:
>
> HOSTCC samples/bpf/test_lru_dist
> samples/bpf/test_lru_dist.c:39:8: error: redefinition of ‘struct list_head’
> struct list_head {
> ^~~~~~~~~
> In file included from samples/bpf/test_lru_dist.c:9:0:
> ../tools/include/linux/types.h:69:8: note: originally defined here
> struct list_head {
> ^~~~~~~~~
>
> Try to detect this situation, and print a helpful warning.
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2019-06-06 0:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 23:47 [PATCH bpf-next v2] samples: bpf: print a warning about headers_install Jakub Kicinski
2019-06-06 0:03 ` Martin Lau [this message]
2019-06-06 0:18 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606000326.mrgtzfud55a4kczj@kafai-mbp.dhcp.thefacebook.com \
--to=kafai@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).