From: Oliver Neukum <oneukum@suse.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: Oliver Neukum <oneukum@suse.com>
Subject: [PATCH 2/6] usb: hso: no complaint about kmalloc failure
Date: Thu, 6 Jun 2019 14:55:44 +0200 [thread overview]
Message-ID: <20190606125548.18315-2-oneukum@suse.com> (raw)
In-Reply-To: <20190606125548.18315-1-oneukum@suse.com>
If this fails, kmalloc() will print a report including
a stack trace. There is no need for a separate complaint.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/net/usb/hso.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 6a0ecddff310..fe1d7bdc8afe 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2474,10 +2474,9 @@ static void hso_create_rfkill(struct hso_device *hso_dev,
&interface_to_usbdev(interface)->dev,
RFKILL_TYPE_WWAN,
&hso_rfkill_ops, hso_dev);
- if (!hso_net->rfkill) {
- dev_err(dev, "%s - Out of memory\n", __func__);
+ if (!hso_net->rfkill)
return;
- }
+
if (rfkill_register(hso_net->rfkill) < 0) {
rfkill_destroy(hso_net->rfkill);
hso_net->rfkill = NULL;
--
2.16.4
next prev parent reply other threads:[~2019-06-06 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 12:55 [PATCH 1/6] usb: hso: correct debug message Oliver Neukum
2019-06-06 12:55 ` Oliver Neukum [this message]
2019-06-06 12:55 ` [PATCH 3/6] usb: hso: switch definitions to the BIT macro Oliver Neukum
2019-06-06 12:55 ` [PATCH 4/6] usb: hso: declare endianness Oliver Neukum
2019-06-06 12:55 ` [PATCH 5/6] usb: hso: obey DMA rules in tiocmget Oliver Neukum
2019-06-06 12:55 ` [PATCH 6/6] usb: hso: remove bogus check for EINPROGRESS Oliver Neukum
2019-06-06 18:18 ` [PATCH 1/6] usb: hso: correct debug message David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606125548.18315-2-oneukum@suse.com \
--to=oneukum@suse.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).