From: Stephen Hemminger <stephen@networkplumber.org>
To: "Patel, Vedang" <vedang.patel@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"Gomes, Vinicius" <vinicius.gomes@intel.com>,
"Dorileo, Leandro" <leandro.maciel.dorileo@intel.com>,
"jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>,
"m-karicheri2@ti.com" <m-karicheri2@ti.com>
Subject: Re: [PATCH iproute2 net-next v1 3/6] taprio: Add support for enabling offload mode
Date: Thu, 6 Jun 2019 14:46:40 -0700 [thread overview]
Message-ID: <20190606144640.1611428d@hermes.lan> (raw)
In-Reply-To: <E3C41041-64E5-4C95-9057-1F2A0E6ECEAC@intel.com>
On Thu, 6 Jun 2019 21:13:50 +0000
"Patel, Vedang" <vedang.patel@intel.com> wrote:
> > On Jun 6, 2019, at 12:43 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> > On Thu, 6 Jun 2019 10:52:18 -0700
> > Vedang Patel <vedang.patel@intel.com> wrote:
> >
> >> @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
> >> struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1];
> >> struct tc_mqprio_qopt *qopt = 0;
> >> __s32 clockid = CLOCKID_INVALID;
> >> + __u32 offload_flags = 0;
> >> int i;
> >>
> >> if (opt == NULL)
> >> @@ -442,6 +458,11 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
> >>
> >> print_string(PRINT_ANY, "clockid", "clockid %s", get_clock_name(clockid));
> >>
> >> + if (tb[TCA_TAPRIO_ATTR_OFFLOAD_FLAGS])
> >> + offload_flags = rta_getattr_u32(tb[TCA_TAPRIO_ATTR_OFFLOAD_FLAGS]);
> >> +
> >> + print_uint(PRINT_ANY, "offload", " offload %x", offload_flags);
> >
> > I don't think offload flags should be printed at all if not present.
> >
> > Why not?
> Will make this in the next version.
Mostly this is so that output doesn't change for users who aren't using offload or have old kernel.
next prev parent reply other threads:[~2019-06-06 21:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 17:52 [PATCH iproute2 net-next v1 1/6] Kernel header update for hardware offloading changes Vedang Patel
2019-06-06 17:52 ` [PATCH iproute2 net-next v1 2/6] etf: Add skip_sock_check Vedang Patel
2019-06-06 17:52 ` [PATCH iproute2 net-next v1 3/6] taprio: Add support for enabling offload mode Vedang Patel
2019-06-06 19:43 ` Stephen Hemminger
2019-06-06 21:13 ` Patel, Vedang
2019-06-06 21:46 ` Stephen Hemminger [this message]
2019-06-06 22:22 ` Patel, Vedang
2019-06-06 17:52 ` [PATCH iproute2 net-next v1 4/6] taprio: add support for setting txtime_delay Vedang Patel
2019-06-06 19:44 ` Stephen Hemminger
2019-06-06 21:11 ` Patel, Vedang
2019-06-06 17:52 ` [PATCH iproute2 net-next v1 5/6] tc: etf: Add documentation for skip-skb-check Vedang Patel
2019-06-06 17:52 ` [PATCH iproute2 net-next v1 6/6] tc: taprio: Update documentation Vedang Patel
2019-06-06 21:15 ` [PATCH iproute2 net-next v1 1/6] Kernel header update for hardware offloading changes Patel, Vedang
-- strict thread matches above, loose matches on Subject: below --
2019-05-28 17:52 Vedang Patel
2019-05-28 17:52 ` [PATCH iproute2 net-next v1 3/6] taprio: Add support for enabling offload mode Vedang Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606144640.1611428d@hermes.lan \
--to=stephen@networkplumber.org \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=leandro.maciel.dorileo@intel.com \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=vedang.patel@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).